Skip to content

Arm backend: add missing buck deps for transform passes in arm_pass_manager#19191

Merged
rascani merged 1 commit intopytorch:mainfrom
rascani:arm-buck-fixes
Apr 28, 2026
Merged

Arm backend: add missing buck deps for transform passes in arm_pass_manager#19191
rascani merged 1 commit intopytorch:mainfrom
rascani:arm-buck-fixes

Conversation

@rascani
Copy link
Copy Markdown
Contributor

@rascani rascani commented Apr 28, 2026

Summary

arm_pass_manager.py imports three transform modules that were missing from the arm_pass_manager_base buck target deps:

  • fuse_cascaded_transpose_or_permute_ops
  • postpone_permute_below_squeeze_view
  • remove_permutes_around_elementwise_ops

This caused ModuleNotFoundError at import time, breaking ARM backend test collection.

Differential Revision: D102650122

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

…anager

arm_pass_manager.py imports three transform modules that were missing
from the arm_pass_manager_base buck target deps:
- fuse_cascaded_transpose_or_permute_ops
- postpone_permute_below_squeeze_view
- remove_permutes_around_elementwise_ops

This caused ModuleNotFoundError at import time, breaking ARM backend
test collection.

Differential Revision: D102650122
@rascani rascani requested a review from mcremon-meta April 28, 2026 16:18
@rascani rascani requested a review from digantdesai as a code owner April 28, 2026 16:18
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 28, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19191

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Awaiting Approval, 2 New Failures, 5 Cancelled Jobs, 6 Pending, 5 Unrelated Failures

As of commit 0c90a57 with merge base 9207001 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Apr 28, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani rascani merged commit c4ec988 into pytorch:main Apr 28, 2026
421 of 440 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants