Skip to content

Qualcomm AI Engine Direct - fix attention sink feature#19203

Merged
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
CodeLinaro:dev1/danny/fix_attn_sink
Apr 29, 2026
Merged

Qualcomm AI Engine Direct - fix attention sink feature#19203
abhinaykukkadapu merged 1 commit intopytorch:mainfrom
CodeLinaro:dev1/danny/fix_attn_sink

Conversation

@DannyYuyang-quic
Copy link
Copy Markdown
Contributor

@DannyYuyang-quic DannyYuyang-quic commented Apr 29, 2026

Summary

Fix Attention sink feature

Test plan

TestExampleLLMScript.test_attention_sink in ./backends/qualcomm/tests/test_qnn_delegate.py

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 29, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19203

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⚠️ 11 Awaiting Approval

As of commit 3801209 with merge base 5a206ab (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 29, 2026
@DannyYuyang-quic
Copy link
Copy Markdown
Contributor Author

Hi @abhinaykukkadapu,
After we removed prefill calibration in LLM, we accidentally removed the indexing for the attention sink feature. This PR adds it back.
Please have a look.
Thanks!

@DannyYuyang-quic
Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot Bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Apr 29, 2026
@abhinaykukkadapu abhinaykukkadapu merged commit e270e8f into pytorch:main Apr 29, 2026
163 of 168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants