Skip to content

Add null checks in tensor parser to prevent SIGSEGV #19267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rascani merged 2 commits into from
May 12, 2026
Merged

Add null checks in tensor parser to prevent SIGSEGV #19267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0fa552
Add null checks in tensor parser to prevent SIGSEGV
rascani May 1, 2026
a46ab55
Merge branch 'main' into export-D103467786
rascani May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions runtime/executor/tensor_parser_exec_aten.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ ET_NODISCARD Result<void*> getMemPlannedPtr(
const executorch_flatbuffer::AllocationDetails* allocation_info,
size_t nbytes,
HierarchicalAllocator* allocator) {
ET_CHECK_OR_RETURN_ERROR(
allocator != nullptr,
InvalidState,
"HierarchicalAllocator must not be null for memory-planned tensor");
// Normal non-constant Tensor. Allocate data using mem_id and offset.

// TODO(T142455629): make the allocator actually id based and not indexed
Expand Down Expand Up @@ -189,6 +193,13 @@ ET_NODISCARD Result<void*> getTensorDataPtr(
const executorch_flatbuffer::AllocationDetails* allocation_info =
s_tensor->allocation_info();

if (allocation_info != nullptr) {
ET_CHECK_OR_RETURN_ERROR(
allocator != nullptr,
InvalidState,
"HierarchicalAllocator is null but tensor has allocation_info requiring memory-planned buffers");
}

// External tensors.
if (s_tensor->extra_tensor_info() != nullptr &&
s_tensor->extra_tensor_info()->location() ==
Expand Down
Loading