Skip to content

Arm backend: Reorder BN-fusing and decomposition#19276

Merged
oscarandersson8218 merged 1 commit intopytorch:mainfrom
oscarandersson8218:reorder_bn_fusing_decomp
May 5, 2026
Merged

Arm backend: Reorder BN-fusing and decomposition#19276
oscarandersson8218 merged 1 commit intopytorch:mainfrom
oscarandersson8218:reorder_bn_fusing_decomp

Conversation

@oscarandersson8218
Copy link
Copy Markdown
Collaborator

@oscarandersson8218 oscarandersson8218 commented May 4, 2026

Make sure BN-fusing pass is run before decomposition pass.

cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19276

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Cancelled Job, 1 Pending, 6 Unrelated Failures

As of commit 144df55 with merge base 0a113f8 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 4, 2026
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels May 4, 2026
- Make sure BN-fusing pass is run before decomposition pass as folding
is more efficient then decomposition.
- Skip FuseBatchNorm2dPass for bf16 batchnorm outputs as folding
conv+batchnorm into bf16 conv weights introduces larger numerical error
than the unfused path, which caused regressions in bf16 tests.
- Add a regression test covering the bf16 non-fusion behavior.
- Fix the bias placeholder validation in the pass to check the bias
node instead of the weight node.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I62b34ab70bfa537bd0ee9fa664433d6ccb279a09
@oscarandersson8218 oscarandersson8218 force-pushed the reorder_bn_fusing_decomp branch from 08e7a62 to 144df55 Compare May 5, 2026 08:16
@oscarandersson8218
Copy link
Copy Markdown
Collaborator Author

Unrelated failures.

@oscarandersson8218 oscarandersson8218 merged commit 8a397b4 into pytorch:main May 5, 2026
428 of 443 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants