Skip to content

Relax lora string test#19312

Merged
JacobSzwejbka merged 1 commit intomainfrom
relax-lora
May 5, 2026
Merged

Relax lora string test#19312
JacobSzwejbka merged 1 commit intomainfrom
relax-lora

Conversation

@JacobSzwejbka
Copy link
Copy Markdown
Contributor

@JacobSzwejbka JacobSzwejbka commented May 5, 2026

Seeing small numerical flakeyness causing diverging output. The output is roughly equivalent though. Current thought is different cpu architectures causing different xnnpack kernels to trigger causing minor difference in output.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19312

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

lucylq
lucylq reviewed May 5, 2026
View reviewed changes
Comment thread .ci/scripts/test_lora.sh
The answer is: 12<|im_end|>"
EXPECTED_QUANT_LORA_ALTERNATE_PREFIX="
<|im_start|>user Calculate 15% of 80?<|im_end|><|im_start|>assistant
To calculate 15% of 80, we can multiply 80 by 15/100.
Copy link
Copy Markdown
Contributor

@lucylq lucylq May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could cut the prefix to here to avoid having two prefixes?

@JacobSzwejbka JacobSzwejbka merged commit 165ac2e into main May 5, 2026
321 of 331 checks passed
@JacobSzwejbka JacobSzwejbka deleted the relax-lora branch May 5, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq lucylq approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JacobSzwejbka @lucylq