Skip to content

Cadence tests should retry#19313

Merged
JacobSzwejbka merged 1 commit intomainfrom
retry-cadence
May 5, 2026
Merged

Cadence tests should retry#19313
JacobSzwejbka merged 1 commit intomainfrom
retry-cadence

Conversation

@JacobSzwejbka
Copy link
Copy Markdown
Contributor

@JacobSzwejbka JacobSzwejbka commented May 5, 2026

With these giant 500+ op tests we often will get a flakey 1/500 failure. Just adding retries to make this a little less noisy.

Failure is something like FAILED backends/cadence/aot/tests/test_replace_ops_passes.py::TestReplaceOpsPasses::test_replace_conv2d_with_linear - AssertionError: Pass validation failed for pass ReplaceTrivialConvWithLinear. Output tensor 0 differs by max 1.525879e-05. Expected rtol=2e-05, atol=1e-06. Original output: tensor([[[[ 6.5604]],

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19313

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 144 Pending

As of commit 7243f09 with merge base 165ac2e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka JacobSzwejbka merged commit 5d07ce0 into main May 5, 2026
165 of 177 checks passed
@JacobSzwejbka JacobSzwejbka deleted the retry-cadence branch May 5, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants