Skip to content

Re-apply U55 reject split for bool permute test#19320

Merged
psiddh merged 1 commit intopytorch:mainfrom
psiddh:export-D103963260
May 6, 2026
Merged

Re-apply U55 reject split for bool permute test#19320
psiddh merged 1 commit intopytorch:mainfrom
psiddh:export-D103963260

Conversation

@psiddh
Copy link
Copy Markdown
Contributor

@psiddh psiddh commented May 6, 2026

Summary:
Forward fix on top of D103817917 (Arm backend: Cleanup dim-order and permute handling — DiffTrain import of upstream PR #19278).

D103817917 reverted an internally-applied test split: the bool
permute case (rank2_bool) is U55-rejected and was already moved
out of the U55-delegating test on master into a separate
test_data_suite_u55_reject set with a dedicated
test_permute_u55_INT_not_delegated test using
OpNotSupportedPipeline. Upstream PR #19278 doesn't include that
split, so the DiffTrain import wipes it out and brings back the
combined test_data_suite + special-cased bool branch in
test_permute_u55_INT. That regresses CI:
test_permute_u55_INT[rank2_bool] is reported as a critical
LAND_BLOCKING failure on D103817917.

Re-apply the split so trunk returns to the clean form after
D103817917 lands:

  • Add OpNotSupportedPipeline import.
  • Move rank2_bool out of test_data_suite into a new
    test_data_suite_u55_reject dict.
  • Drop the dead if test_data[0].dtype == torch.bool: ...
    workaround block from test_permute_u55_INT (no bool flows
    through this test anymore).
  • Add test_permute_u55_INT_not_delegated parametrized over
    test_data_suite_u55_reject, exercising
    OpNotSupportedPipeline with u55_subset=True.

The test_data_suite_u55 dict introduced by D103817917 (large
permutes that only U55 needs to exercise) is preserved unchanged.

Differential Revision: D103963260

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Summary:
Forward fix on top of D103817917 (`Arm backend: Cleanup dim-order
and permute handling` — DiffTrain import of upstream PR pytorch#19278).

D103817917 reverted an internally-applied test split: the bool
permute case (`rank2_bool`) is U55-rejected and was already moved
out of the U55-delegating test on master into a separate
`test_data_suite_u55_reject` set with a dedicated
`test_permute_u55_INT_not_delegated` test using
`OpNotSupportedPipeline`. Upstream PR pytorch#19278 doesn't include that
split, so the DiffTrain import wipes it out and brings back the
combined `test_data_suite` + special-cased bool branch in
`test_permute_u55_INT`. That regresses CI:
`test_permute_u55_INT[rank2_bool]` is reported as a critical
LAND_BLOCKING failure on D103817917.

Re-apply the split so trunk returns to the clean form after
D103817917 lands:
- Add `OpNotSupportedPipeline` import.
- Move `rank2_bool` out of `test_data_suite` into a new
  `test_data_suite_u55_reject` dict.
- Drop the dead `if test_data[0].dtype == torch.bool: ...`
  workaround block from `test_permute_u55_INT` (no bool flows
  through this test anymore).
- Add `test_permute_u55_INT_not_delegated` parametrized over
  `test_data_suite_u55_reject`, exercising
  `OpNotSupportedPipeline` with `u55_subset=True`.

The `test_data_suite_u55` dict introduced by D103817917 (large
permutes that only U55 needs to exercise) is preserved unchanged.

Differential Revision: D103963260
Copilot AI review requested due to automatic review settings May 6, 2026 01:50
@psiddh psiddh requested a review from digantdesai as a code owner May 6, 2026 01:50
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19320

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 30 Pending, 1 Unrelated Failure

As of commit 9dda9f6 with merge base 5faf36e (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 6, 2026

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103963260.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-applies the previously existing U55 reject split for the bool permute test case in Arm backend op tests, restoring CI stability after a prior import/cleanup reverted the split.

Changes:

  • Import OpNotSupportedPipeline for non-delegation validation.
  • Move the rank2_bool permute case out of the U55-delegating suite into a dedicated test_data_suite_u55_reject.
  • Remove the bool-specific workaround in test_permute_u55_INT and add test_permute_u55_INT_not_delegated to assert the op is not delegated on U55.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +121 to +123
@common.parametrize("test_data", test_data_suite_u55_reject)
def test_permute_u55_INT_not_delegated(test_data: torch.Tensor):
test_data, dims = test_data()
@psiddh psiddh merged commit 1debeb6 into pytorch:main May 6, 2026
444 of 468 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants