Re-apply U55 reject split for bool permute test#19320
Conversation
Summary: Forward fix on top of D103817917 (`Arm backend: Cleanup dim-order and permute handling` — DiffTrain import of upstream PR pytorch#19278). D103817917 reverted an internally-applied test split: the bool permute case (`rank2_bool`) is U55-rejected and was already moved out of the U55-delegating test on master into a separate `test_data_suite_u55_reject` set with a dedicated `test_permute_u55_INT_not_delegated` test using `OpNotSupportedPipeline`. Upstream PR pytorch#19278 doesn't include that split, so the DiffTrain import wipes it out and brings back the combined `test_data_suite` + special-cased bool branch in `test_permute_u55_INT`. That regresses CI: `test_permute_u55_INT[rank2_bool]` is reported as a critical LAND_BLOCKING failure on D103817917. Re-apply the split so trunk returns to the clean form after D103817917 lands: - Add `OpNotSupportedPipeline` import. - Move `rank2_bool` out of `test_data_suite` into a new `test_data_suite_u55_reject` dict. - Drop the dead `if test_data[0].dtype == torch.bool: ...` workaround block from `test_permute_u55_INT` (no bool flows through this test anymore). - Add `test_permute_u55_INT_not_delegated` parametrized over `test_data_suite_u55_reject`, exercising `OpNotSupportedPipeline` with `u55_subset=True`. The `test_data_suite_u55` dict introduced by D103817917 (large permutes that only U55 needs to exercise) is preserved unchanged. Differential Revision: D103963260
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19320
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 30 Pending, 1 Unrelated FailureAs of commit 9dda9f6 with merge base 5faf36e ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103963260. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Re-applies the previously existing U55 reject split for the bool permute test case in Arm backend op tests, restoring CI stability after a prior import/cleanup reverted the split.
Changes:
- Import
OpNotSupportedPipelinefor non-delegation validation. - Move the
rank2_boolpermute case out of the U55-delegating suite into a dedicatedtest_data_suite_u55_reject. - Remove the bool-specific workaround in
test_permute_u55_INTand addtest_permute_u55_INT_not_delegatedto assert the op is not delegated on U55.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @common.parametrize("test_data", test_data_suite_u55_reject) | ||
| def test_permute_u55_INT_not_delegated(test_data: torch.Tensor): | ||
| test_data, dims = test_data() |
Summary:
Forward fix on top of D103817917 (
Arm backend: Cleanup dim-order and permute handling— DiffTrain import of upstream PR #19278).D103817917 reverted an internally-applied test split: the bool
permute case (
rank2_bool) is U55-rejected and was already movedout of the U55-delegating test on master into a separate
test_data_suite_u55_rejectset with a dedicatedtest_permute_u55_INT_not_delegatedtest usingOpNotSupportedPipeline. Upstream PR #19278 doesn't include thatsplit, so the DiffTrain import wipes it out and brings back the
combined
test_data_suite+ special-cased bool branch intest_permute_u55_INT. That regresses CI:test_permute_u55_INT[rank2_bool]is reported as a criticalLAND_BLOCKING failure on D103817917.
Re-apply the split so trunk returns to the clean form after
D103817917 lands:
OpNotSupportedPipelineimport.rank2_boolout oftest_data_suiteinto a newtest_data_suite_u55_rejectdict.if test_data[0].dtype == torch.bool: ...workaround block from
test_permute_u55_INT(no bool flowsthrough this test anymore).
test_permute_u55_INT_not_delegatedparametrized overtest_data_suite_u55_reject, exercisingOpNotSupportedPipelinewithu55_subset=True.The
test_data_suite_u55dict introduced by D103817917 (largepermutes that only U55 needs to exercise) is preserved unchanged.
Differential Revision: D103963260
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell