Add optional offset arg to quantized_conv1d_nlc and precompute it AOT (#19344)#19344
Add optional offset arg to quantized_conv1d_nlc and precompute it AOT (#19344)#19344khazaei wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19344
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 18 Unrelated FailuresAs of commit 8c1a576 with merge base af90130 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@khazaei has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103893688. |
This PR needs a
|
…pytorch#19344) Summary: Extends `cadence::quantized_conv1d_nlc` (per_tensor / per_tensor_out) with an optional `offset` tensor that carries the precomputed zero-point correction term `-(sum(W) * X_z)` per output channel. - Updates the op schema in functions.yaml / functions_hifi.yaml / ops_registrations.py to add `Tensor? offset=None`. - Threads the new `offset` argument through the generic and HiFi conv1d_nlc kernels (currently unused by these kernels). - Updates the depthwise conv1d_nlc callers to pass an empty optional. - Extends `PrecomputeForQuantizedConvPass` to also precompute the offset for `quantized_conv1d_nlc.per_tensor` (sum over weight dims [1, 2]) and adds a unit test for the new path. Reviewed By: abeakkas Differential Revision: D103893688
…pytorch#19344) Summary: Extends `cadence::quantized_conv1d_nlc` (per_tensor / per_tensor_out) with an optional `offset` tensor that carries the precomputed zero-point correction term `-(sum(W) * X_z)` per output channel. - Updates the op schema in functions.yaml / functions_hifi.yaml / ops_registrations.py to add `Tensor? offset=None`. - Threads the new `offset` argument through the generic and HiFi conv1d_nlc kernels (currently unused by these kernels). - Updates the depthwise conv1d_nlc callers to pass an empty optional. - Extends `PrecomputeForQuantizedConvPass` to also precompute the offset for `quantized_conv1d_nlc.per_tensor` (sum over weight dims [1, 2]) and adds a unit test for the new path. Reviewed By: abeakkas Differential Revision: D103893688
…pytorch#19344) Summary: Extends `cadence::quantized_conv1d_nlc` (per_tensor / per_tensor_out) with an optional `offset` tensor that carries the precomputed zero-point correction term `-(sum(W) * X_z)` per output channel. - Updates the op schema in functions.yaml / functions_hifi.yaml / ops_registrations.py to add `Tensor? offset=None`. - Threads the new `offset` argument through the generic and HiFi conv1d_nlc kernels (currently unused by these kernels). - Updates the depthwise conv1d_nlc callers to pass an empty optional. - Extends `PrecomputeForQuantizedConvPass` to also precompute the offset for `quantized_conv1d_nlc.per_tensor` (sum over weight dims [1, 2]) and adds a unit test for the new path. Reviewed By: abeakkas Differential Revision: D103893688
Summary:
Extends
cadence::quantized_conv1d_nlc(per_tensor / per_tensor_out) withan optional
offsettensor that carries the precomputed zero-pointcorrection term
-(sum(W) * X_z)per output channel.ops_registrations.py to add
Tensor? offset=None.offsetargument through the generic and HiFi conv1d_nlckernels (currently unused by these kernels).
PrecomputeForQuantizedConvPassto also precompute the offsetfor
quantized_conv1d_nlc.per_tensor(sum over weight dims [1, 2]) andadds a unit test for the new path.
Reviewed By: abeakkas
Differential Revision: D103893688