Make op_upsample_bilinear2d_aa_test deterministic

[psiddh]

Summary:
Three test methods in
fbcode/executorch/kernels/portable/test/op_upsample_bilinear2d_aa_test.py
have been auto-disabled as flaky on the test-issues dashboard
(owner ai_infra_mobile_platform):

• test_upsample_bilinear2d_aa_aten_parity_u8
• test_upsample_bilinear2d_aa_aggressive_downsampling
• test_upsample_bilinear2d_aa_align_corners_downsampling

Root cause: each test builds its input via torch.randint(...) or
torch.randn(...) with no seed pinned, so each run sees a different
sample. The configured atol was tight enough that on some draws the
ATen-vs-ExecuTorch divergence (driven by separable-vs-direct
anti-aliased interpolation differences) crossed the threshold and the
test flipped to FAIL. The kernel implementations themselves are not
changing across runs.

Fix:

1. Add setUp(self): torch.manual_seed(0) so every run sees the same
   input tensor and the same divergence, eliminating the run-to-run
   FAIL/PASS oscillation.
2. Bump two atol thresholds to cover the worst-case observed
   divergence with the now-pinned input:
   • u8 parity: 3.5 -> 5 (observed max abs error 4 / 255)
   • aggressive 4x downsampling: 0.4 -> 1.0 (observed max abs error
     ~0.59 for N(0,1) input)
3. The pre-existing atol=0.25 on align_corners_downsampling is left
   unchanged - with seed 0 it now passes consistently.

The relaxed tolerances are still well below any change that would
indicate an actual kernel regression; the comprehensive C++ test
suite in op_upsample_bilinear2d_aa_test.cpp still validates the
kernel under tighter constraints.

Reviewed By: rascani

Differential Revision: D104150928

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19357

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 20 Pending

As of commit f2388dd with merge base b3baac5 ():

NEW FAILURE - The following job has failed:

• Docathon Labels Sync / check-labels (gh)
  Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-codesync]

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104150928.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[Copilot]

Pull request overview

This PR addresses test flakiness in the portable anti-aliased bilinear upsample parity tests by making their randomized inputs deterministic, and updates the iOS LLM Apple BUCK rule’s test timeout/label configuration to accommodate very long-running XCTest inference runs.

Changes:

• Seed PyTorch RNG in UpsampleBilinear2dAATest to make randn/randint inputs deterministic across runs.
• Relax atol for two specific flaky parity tests to match the observed worst-case divergence under the pinned seed.
• Update Apple LLM BUCK test labeling/timeouts to allow significantly longer XCTest execution.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
kernels/portable/test/op_upsample_bilinear2d_aa_test.py	Pins RNG for deterministic inputs and adjusts tolerances to eliminate flakes in ATen-vs-ExecuTorch parity checks.
extension/llm/apple/BUCK	Changes test label and increases overall test rule timeout to support long-running iOS-sim LLM inference tests.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[psiddh]

@claude review this PR and the comment from Copilot , seems reasonable

[claude]

Claude finished @psiddh's task in 1m 3s —— View job

---

Review of PR #19357

• Read the changed file and understand the diff
• Evaluate Copilot's suggestion about RNG state isolation
• Provide review feedback

---

Overall: This PR looks good. The fix is straightforward and the approach (pinning the seed + adjusting tolerances) is the standard pattern for making flaky numerical-parity tests deterministic.

On Copilot's suggestion (RNG state save/restore)

Copilot's suggestion to save/restore RNG state via torch.get_rng_state()/set_rng_state() in tearDown() (or use torch.random.fork_rng()) is technically correct but not practically necessary here. Reasons:

1. This test file runs in its own process — Python unittest discovery typically isolates test modules. Even if it doesn't, the standard unittest runner doesn't guarantee RNG state across classes anyway.
2. Other tests in this repo also call torch.manual_seed() at module/function scope without restoring state (e.g., kernels/test/test_case_gen.py calls it at module level, backends/test/suite/runner.py calls it per test). This is the established pattern in the codebase.
3. The added complexity isn't worth it — setUp+tearDown RNG save/restore adds 4+ lines for a scenario that doesn't occur in practice. If a future test in this file needs different randomness, it can simply call torch.manual_seed(N) with a different seed.

So the current approach of just torch.manual_seed(0) in setUp is fine and consistent with the rest of the repo. I'd dismiss the Copilot comment.

Minor observations

• The tolerance bumps (3.5→5 for u8, 0.4→1.0 for aggressive downsampling) are well-justified in the comments and the PR description explains the observed error magnitudes.
• The comments on lines 26-27 and at the tolerance sites are helpful since they explain why the values were chosen — this is one of the few cases where comments genuinely add value.
• The align_corners_downsampling test keeping atol=0.25 unchanged (passes with seed 0) is a good sign that the seed choice isn't just masking broader issues.

LGTM — no blocking concerns.

---

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.