Restore VGF skip guards and preload_deps shape#19375
Conversation
Summary: Restores two pieces of test plumbing in backends/arm/test/ that were inadvertently removed from pytorch/executorch on GitHub and are still required for stable CI: 1. _VGF_ENABLED skip-guards in test_rewrite_conv_pass.py — without them, three VGF tests crash (rather than skip) on environments where LAVAPIPE_LIB_PATH is unset. 2. preload_deps shape in targets.bzl — the prior refactor silently dropped //executorch/kernels/quantized:custom_ops_generated_lib from every non-VGF arm test whenever runtime.is_oss or not _ENABLE_VGF. The guards are no-ops on environments that have lavapipe configured, so this is a strict safety improvement for OSS CI and a divergence fix for fbsource. This supersedes the long-stuck fix-up diff D100742931 (which will be abandoned). Differential Revision: D104267179
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19375
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 45 Pending, 1 Unrelated FailureAs of commit f32e20f with merge base 1643611 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104267179. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Restores Arm backend test “plumbing” needed to keep CI stable when VGF/Vulkan emulation isn’t configured, and to ensure quantized custom ops registration is consistently preloaded for Arm tests.
Changes:
- Reintroduces
pytest.skipifguards for VGF-specific conv rewrite tests whenLAVAPIPE_LIB_PATHis not set, preventing crashes in non-VGF environments. - Restores
preload_depscomposition so//executorch/kernels/quantized:custom_ops_generated_libis always preloaded, while VGF-specific deps remain conditional.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backends/arm/test/targets.bzl | Ensures custom_ops_generated_lib is always present in preload_deps, and conditionally appends VGF/Vulkan preload deps only when applicable. |
| backends/arm/test/passes/test_rewrite_conv_pass.py | Adds environment-based VGF enablement detection and skip guards for three VGF-only tests to avoid crashing when lavapipe isn’t configured. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
unrelated failures |
Summary:
Restores two pieces of test plumbing in backends/arm/test/ that were
inadvertently removed from pytorch/executorch on GitHub and are still
required for stable CI:
them, three VGF tests crash (rather than skip) on environments where
LAVAPIPE_LIB_PATH is unset.
dropped //executorch/kernels/quantized:custom_ops_generated_lib from
every non-VGF arm test whenever runtime.is_oss or not _ENABLE_VGF.
The guards are no-ops on environments that have lavapipe configured, so
this is a strict safety improvement for OSS CI and a divergence fix for
fbsource. This supersedes the long-stuck fix-up diff D100742931 (which
will be abandoned).
Differential Revision: D104267179
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell