Skip to content

Restore VGF skip guards and preload_deps shape#19375

Merged
psiddh merged 1 commit intopytorch:mainfrom
psiddh:export-D104267179
May 7, 2026
Merged

Restore VGF skip guards and preload_deps shape#19375
psiddh merged 1 commit intopytorch:mainfrom
psiddh:export-D104267179

Conversation

@psiddh
Copy link
Copy Markdown
Contributor

@psiddh psiddh commented May 7, 2026

Summary:
Restores two pieces of test plumbing in backends/arm/test/ that were
inadvertently removed from pytorch/executorch on GitHub and are still
required for stable CI:

  1. _VGF_ENABLED skip-guards in test_rewrite_conv_pass.py — without
    them, three VGF tests crash (rather than skip) on environments where
    LAVAPIPE_LIB_PATH is unset.
  2. preload_deps shape in targets.bzl — the prior refactor silently
    dropped //executorch/kernels/quantized:custom_ops_generated_lib from
    every non-VGF arm test whenever runtime.is_oss or not _ENABLE_VGF.

The guards are no-ops on environments that have lavapipe configured, so
this is a strict safety improvement for OSS CI and a divergence fix for
fbsource. This supersedes the long-stuck fix-up diff D100742931 (which
will be abandoned).

Differential Revision: D104267179

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Summary:
Restores two pieces of test plumbing in backends/arm/test/ that were
inadvertently removed from pytorch/executorch on GitHub and are still
required for stable CI:

1. _VGF_ENABLED skip-guards in test_rewrite_conv_pass.py — without
   them, three VGF tests crash (rather than skip) on environments where
   LAVAPIPE_LIB_PATH is unset.
2. preload_deps shape in targets.bzl — the prior refactor silently
   dropped //executorch/kernels/quantized:custom_ops_generated_lib from
   every non-VGF arm test whenever runtime.is_oss or not _ENABLE_VGF.

The guards are no-ops on environments that have lavapipe configured, so
this is a strict safety improvement for OSS CI and a divergence fix for
fbsource. This supersedes the long-stuck fix-up diff D100742931 (which
will be abandoned).

Differential Revision: D104267179
Copilot AI review requested due to automatic review settings May 7, 2026 18:06
@psiddh psiddh requested a review from digantdesai as a code owner May 7, 2026 18:06
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19375

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 45 Pending, 1 Unrelated Failure

As of commit f32e20f with merge base 1643611 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 7, 2026

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104267179.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores Arm backend test “plumbing” needed to keep CI stable when VGF/Vulkan emulation isn’t configured, and to ensure quantized custom ops registration is consistently preloaded for Arm tests.

Changes:

  • Reintroduces pytest.skipif guards for VGF-specific conv rewrite tests when LAVAPIPE_LIB_PATH is not set, preventing crashes in non-VGF environments.
  • Restores preload_deps composition so //executorch/kernels/quantized:custom_ops_generated_lib is always preloaded, while VGF-specific deps remain conditional.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
backends/arm/test/targets.bzl Ensures custom_ops_generated_lib is always present in preload_deps, and conditionally appends VGF/Vulkan preload deps only when applicable.
backends/arm/test/passes/test_rewrite_conv_pass.py Adds environment-based VGF enablement detection and skip guards for three VGF-only tests to avoid crashing when lavapipe isn’t configured.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@psiddh
Copy link
Copy Markdown
Contributor Author

psiddh commented May 7, 2026

unrelated failures

@psiddh psiddh merged commit d5ba603 into pytorch:main May 7, 2026
450 of 460 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: arm Issues related to arm backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants