Rename build files from TARGETS to BUCK (group ID: -1524544273800567572) (#19414)#19414
Rename build files from TARGETS to BUCK (group ID: -1524544273800567572) (#19414)#19414bigfootjon wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19414
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit cc62981 with merge base 4413a5c ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415545. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Renames/migrates Buck build definitions by moving targets from TARGETS to BUCK and wrapping target declarations with migration macros to support fbcode vs non-fbcode environments.
Changes:
- Convert
extension/audio/BUCKtargets to usefbcode_targetwrappers. - Remove
extension/aten_util/test/TARGETSand merge its intent intoextension/aten_util/test/BUCK. - Introduce
fbcode_target/non_fbcode_targetwrappers inextension/aten_util/test/BUCKto conditionally define common targets.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extension/audio/BUCK | Wrap existing python targets using migration macros for fbcode/non-fbcode handling. |
| extension/aten_util/test/TARGETS | Remove legacy TARGETS entrypoint now that definitions are merged into BUCK. |
| extension/aten_util/test/BUCK | Add migration wrappers and merge prior TARGETS guidance/callsite into BUCK. |
Comments suppressed due to low confidence (1)
extension/audio/BUCK:1
non_fbcode_targetis loaded here but never used in this file. Consider removing it from theload(...)(or wrapping targets that should exist in non-fbcode builds withnon_fbcode_target) to avoid unused/ambiguous migration imports.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| load(":targets.bzl", "define_common_targets") | ||
|
|
||
|
|
| # !!!! fbcode/executorch/extension/aten_util/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! | ||
|
|
||
| # Any targets that should be shared between fbcode and xplat must be defined in | ||
| # targets.bzl. This file can contain fbcode-only targets. | ||
|
|
aeed8f9 to
cc62981
Compare
Summary: Pull Request resolved: #19414
Reviewed By: bigfootjon
Differential Revision: D104415545