Rename build files from TARGETS to BUCK (group ID: 1842302970244970417) (#19428)#19428
Rename build files from TARGETS to BUCK (group ID: 1842302970244970417) (#19428)#19428bigfootjon wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19428
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 PendingAs of commit 8032e69 with merge base 4413a5c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415000. |
There was a problem hiding this comment.
Pull request overview
Migrates several backend build definitions to the BUCK build-file migration pattern by wrapping targets with fbcode_target / non_fbcode_target, and merges the MediaTek runtime TARGETS content into BUCK.
Changes:
- Add
build_file_migration.bzlwrappers and convert existing targets tofbcode_target/non_fbcode_target. - Merge
backends/mediatek/runtime/TARGETSintobackends/mediatek/runtime/BUCK. - Apply the same wrapper conversion for example and CUDA test targets.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| backends/mediatek/runtime/TARGETS | Removed/merged into the corresponding BUCK file as part of the TARGETS→BUCK migration. |
| backends/mediatek/runtime/BUCK | Adds migration wrappers and wraps the neuron_backend cxx library as a non-fbcode target. |
| backends/mediatek/quantizer/BUCK | Wraps the quantizer python library with fbcode_target for migration. |
| backends/example/BUCK | Wraps example python libraries and unittest target with fbcode_target. |
| backends/cuda/tests/BUCK | Wraps CUDA test targets with fbcode_target for migration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -7,9 +9,8 @@ load( | |||
| ) | |||
| load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") | |||
| visibility = ["PUBLIC"], | ||
| ) | ||
|
|
||
| # !!!! fbcode/executorch/backends/mediatek/runtime/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!! |
74bc975 to
8032e69
Compare
Summary: Pull Request resolved: #19428
Reviewed By: bigfootjon
Differential Revision: D104415000