Arm backend: Remove redundant pass insertions#19448
Merged
oscarandersson8218 merged 2 commits intoMay 13, 2026
Merged
Conversation
Decompositions of GRU, LSTM and RNN were inserted in the Arm backend pass pipline even though these operators would have been decomposed in the core-ATen legalization. Also moves tests from test/passes/ to test/modules/ as the tests are end-to-end tests rather than isolated pass tests. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I0bbc06ca724b1b30b936036e71986af16ebf8467
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19448
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (3 Unrelated Failures)As of commit b618756 with merge base b04cc65 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
oscarandersson8218
added
release notes: none
Sebastian-Larsson
approved these changes
May 11, 2026
Contributor
|
I guess the tests added by #17140 are green, so should be ok to merge. |
digantdesai
approved these changes
May 13, 2026
Collaborator
Author
|
Unrelated failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompositions of GRU, LSTM and RNN were inserted in the Arm backend pass pipeline even though these operators would have been decomposed in the core-ATen legalization. Also moves tests from test/passes/ to test/modules/ as the tests are end-to-end tests rather than isolated pass tests.
cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell