Replace GTEST_SKIP() aten guards with #ifndef USE_ATEN_LIB (3/3)#19485
Replace GTEST_SKIP() aten guards with #ifndef USE_ATEN_LIB (3/3)#19485GregoryComer wants to merge 1 commit into
Conversation
Replace runtime `if (is_aten) { GTEST_SKIP() }` checks with compile-time `#ifndef USE_ATEN_LIB` / `#ifdef USE_ATEN_LIB` preprocessor guards around the entire test.
Meta test infra does not handle GTEST_SKIP well, so we use preprocessor guards to exclude aten-incompatible tests at compile time instead of skipping them at runtime.
This commit covers ops n-z (ne through var). Authored with Claude.
Differential Revision: [D104739568](https://our.internmc.facebook.com/intern/diff/D104739568/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19485
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit 4590210 with merge base 23a91d5 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Stack from ghstack (oldest at bottom):
Replace runtime
if (is_aten) { GTEST_SKIP() }checks with compile-time#ifndef USE_ATEN_LIB/#ifdef USE_ATEN_LIBpreprocessor guards around the entire test.Meta test infra does not handle GTEST_SKIP well, so we use preprocessor guards to exclude aten-incompatible tests at compile time instead of skipping them at runtime.
This commit covers ops n-z (ne through var). Authored with Claude.
Differential Revision: D104739568