Skip to content

NXP backend: Add QAT tests for AvgPool, MaxPool and Mul tensor ops#19572

Merged
roman-janik-nxp merged 1 commit into
pytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-909-Add-support-for-QAT-to-new-flow-tests
May 18, 2026
Merged

NXP backend: Add QAT tests for AvgPool, MaxPool and Mul tensor ops#19572
roman-janik-nxp merged 1 commit into
pytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-909-Add-support-for-QAT-to-new-flow-tests

Conversation

@roman-janik-nxp
Copy link
Copy Markdown
Collaborator

@roman-janik-nxp roman-janik-nxp commented May 13, 2026

Summary

Add QAT tests for AvgPool, MaxPool and Mul tensor ops for Neutron backend using the new Neutron MLIR flow.

Test plan

Unit tests provided.

cc @robert-kalmar

@roman-janik-nxp roman-janik-nxp added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels May 13, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 13, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19572

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Cancelled Job

As of commit 1ef312e with merge base 5b89d23 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2026
Comment thread backends/nxp/tests/ir/converter/node_converter/test_mul_tensor_converter.py Outdated
)
from executorch.backends.nxp.tests.graph_verifier import DetailedGraphVerifier
from executorch.backends.nxp.tests.model_output_comparator import (
NumericalStatsOutputComparator,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, why did you use the NumericalStatsOutputComparator for the QAT tests?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was inspired by our internal tests where we use it.

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-909-Add-support-for-QAT-to-new-flow-tests branch from f6266a3 to 1ef312e Compare May 14, 2026 13:35
@roman-janik-nxp roman-janik-nxp changed the title Add QAT tests for AvgPool, MaxPool and Mul tensor ops NXP backend: Add QAT tests for AvgPool, MaxPool and Mul tensor ops May 14, 2026
@roman-janik-nxp
Copy link
Copy Markdown
Collaborator Author

The failing checks seem unrelated and the internal build is passing. Merging.

@roman-janik-nxp roman-janik-nxp merged commit df3fa0d into pytorch:main May 18, 2026
172 of 175 checks passed
@roman-janik-nxp roman-janik-nxp deleted the feature/nxg11066/EIEX-909-Add-support-for-QAT-to-new-flow-tests branch May 18, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants