Decompose sigmoid to exp+reciprocal to fix U85 TABLE bug (#19618)#19618
Decompose sigmoid to exp+reciprocal to fix U85 TABLE bug (#19618)#19618christine-long-meta wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19618
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 2 Cancelled Jobs, 1 Unrelated FailureAs of commit b5c3f62 with merge base dbcf6ac ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105021646. |
This PR needs a
|
84732c4 to
4a69581
Compare
|
Thanks for your contribution @christine-long-meta! This PR seems a bit incomplete as it only modifies tests while the description suggest that there should be changes to passes. Does the PR currently include all the changes you want to make? |
Summary: Add DecomposeSigmoidPass that decomposes sigmoid(x) into reciprocal(add(exp(neg(x)), 1)). This bypasses the broken Vela U85 sigmoid TABLE op by decomposing into primitive ops whose individual TABLE implementations work correctly on U85. The pass runs in both the TFA pipeline (before quantization, so exp/reciprocal get individually annotated for a16w8) and the TOSA pipeline (for FP path). Differential Revision: D105021646
1d6e5e3 to
5632cbe
Compare
@oscarandersson8218 thanks for catching that. I guess the export function went wrong and only exported half. Let me try to fix that |
Summary: Add DecomposeSigmoidPass that decomposes sigmoid(x) into reciprocal(add(exp(neg(x)), 1)). This bypasses the broken Vela U85 sigmoid TABLE op by decomposing into primitive ops whose individual TABLE implementations work correctly on U85. The pass runs in both the TFA pipeline (before quantization, so exp/reciprocal get individually annotated for a16w8) and the TOSA pipeline (for FP path). Differential Revision: D105021646
5632cbe to
b5c3f62
Compare
Summary:
Add DecomposeSigmoidPass that decomposes sigmoid(x) into reciprocal(add(exp(neg(x)), 1)).
This bypasses the broken Vela U85 sigmoid TABLE op by decomposing into
primitive ops whose individual TABLE implementations work correctly on U85.
The pass runs in both the TFA pipeline (before quantization, so exp/reciprocal get
individually annotated for a16w8) and the TOSA pipeline (for FP path).
Differential Revision: D105021646