Skip to content

Arm backend: remove flag from Vk pipeline session#19669

Merged
Erik-Lundell merged 2 commits into
pytorch:mainfrom
Erik-Lundell:remove-flag
May 20, 2026
Merged

Arm backend: remove flag from Vk pipeline session#19669
Erik-Lundell merged 2 commits into
pytorch:mainfrom
Erik-Lundell:remove-flag

Conversation

@Erik-Lundell
Copy link
Copy Markdown
Collaborator

@Erik-Lundell Erik-Lundell commented May 19, 2026

The flag VK_PIPELINE_CREATE_2_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT means
"Do not perform expensive synchronous compilation during this call"

If Vulkan detects that this is needed, it instead
throws an error. We can skip this pre-caution.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

The flag VK_PIPELINE_CREATE_2_FAIL_ON_PIPELINE_COMPILE_REQUIRED_BIT
means
"Do not perform expensive synchronous compilation during this call"

If Vulkan detects that this is needed, it instead
throws an error. We can skip this pre-caution.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: Ib023370c03220d28dc931daf2f9bd89b2c34bfa1
@Erik-Lundell Erik-Lundell requested a review from digantdesai as a code owner May 19, 2026 14:12
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm module: arm Issues related to arm backend labels May 19, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 19, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19669

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (4 Unrelated Failures)

As of commit afc4c87 with merge base 6f052fe (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2026
@Erik-Lundell Erik-Lundell added the release notes: none Do not include this in the release notes label May 19, 2026
@Erik-Lundell Erik-Lundell merged commit 9851477 into pytorch:main May 20, 2026
438 of 445 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants