Skip to content

Revert "Qualcomm AI Engine Direct - heap profiling at runtime with HTP backend"#19705

Merged
metascroy merged 1 commit into
mainfrom
revert-19224-dev1/memory/profiling
May 20, 2026
Merged

Revert "Qualcomm AI Engine Direct - heap profiling at runtime with HTP backend"#19705
metascroy merged 1 commit into
mainfrom
revert-19224-dev1/memory/profiling

Conversation

@metascroy
Copy link
Copy Markdown
Contributor

Reverts #19224

This is failing internal CI tests:

buck test @fbcode//mode/dev fbcode//executorch/backends/qualcomm/tests/fb:test_qnn_delegate_simulator -- --exact 'fbcode//executorch/backends/qualcomm/tests/fb:test_qnn_delegate_simulator - test_qnn_backend_runtime_option_heap_profile (executorch.backends.qualcomm.tests.fb.test_qnn_delegate_simulator.TestQNNQuantizedUtilsSimulator)'

buck test @fbcode//mode/dev fbcode//executorch/backends/qualcomm/tests/fb:test_qnn_delegate_simulator -- --exact 'fbcode//executorch/backends/qualcomm/tests/fb:test_qnn_delegate_simulator - test_qnn_backend_runtime_option_heap_profile (executorch.backends.qualcomm.tests.fb.test_qnn_delegate_simulator.TestQNNFloatingPointUtilsSimulator)'

======================================================================
ERROR: test_qnn_backend_runtime_option_heap_profile (executorch.backends.qualcomm.tests.fb.test_qnn_delegate_simulator.TestQNNFloatingPointUtilsSimulator)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/data/sandcastle/boxes/trunk-hg-full-fbsource/buck-out/v2/art/fbcode/4c4ca07d1cf3712f/executorch/backends/qualcomm/tests/fb/__test_qnn_delegate_simulator__/test_qnn_delegate_simulator#link-tree/executorch/backends/qualcomm/tests/test_qnn_delegate.py", line 5851, in test_qnn_backend_runtime_option_heap_profile
    self.verify_output(
TypeError: TestQNNFloatingPointUtilsSimulator.verify_output() got an unexpected keyword argument 'save_heap_result'

@pytorch-bot pytorch-bot Bot added the ci-no-td label May 20, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 20, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19705

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 110 Pending, 1 Unclassified Failure

As of commit 3cd1868 with merge base 6ba868e (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • Check Labels / Check labels (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    RuntimeError: GraphQL query

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2026
@metascroy metascroy marked this pull request as ready for review May 20, 2026 19:18
@metascroy metascroy merged commit 576ed77 into main May 20, 2026
192 of 196 checks passed
@metascroy metascroy deleted the revert-19224-dev1/memory/profiling branch May 20, 2026 19:54
@psiddh
Copy link
Copy Markdown
Contributor

psiddh commented May 20, 2026

@jethroqti I am working on diff that fixes internal broken tests (internal meta CI), once that diff lands, I will reland this again

@psiddh
Copy link
Copy Markdown
Contributor

psiddh commented May 20, 2026

Here is the revert of revert : #19710

@jethroqti
Copy link
Copy Markdown
Contributor

@jethroqti I am working on diff that fixes internal broken tests (internal meta CI), once that diff lands, I will reland this again

@psiddh No problem. Thanks.

psiddh added a commit that referenced this pull request May 21, 2026
#19710)

… with HTP backend" (#19705)"

This reverts commit 576ed77 which reverted the original heap
profiling feature (#19224). The internal CI test failures that caused
the original revert have been fixed by adding @unittest.skip overrides
for test_qnn_backend_runtime_option_heap_profile in the simulator test
classes.


Original commit changeset: 576ed77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants