Revert "Qualcomm AI Engine Direct - heap profiling at runtime with HTP backend"#19705
Merged
Conversation
…P backen…" This reverts commit 885ebb9.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19705
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 110 Pending, 1 Unclassified FailureAs of commit 3cd1868 with merge base 6ba868e ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
JacobSzwejbka
approved these changes
May 20, 2026
Contributor
|
@jethroqti I am working on diff that fixes internal broken tests (internal meta CI), once that diff lands, I will reland this again |
Contributor
|
Here is the revert of revert : #19710 |
Contributor
@psiddh No problem. Thanks. |
psiddh
added a commit
that referenced
this pull request
May 21, 2026
#19710) … with HTP backend" (#19705)" This reverts commit 576ed77 which reverted the original heap profiling feature (#19224). The internal CI test failures that caused the original revert have been fixed by adding @unittest.skip overrides for test_qnn_backend_runtime_option_heap_profile in the simulator test classes. Original commit changeset: 576ed77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #19224
This is failing internal CI tests:
buck test @fbcode//mode/dev fbcode//executorch/backends/qualcomm/tests/fb:test_qnn_delegate_simulator -- --exact 'fbcode//executorch/backends/qualcomm/tests/fb:test_qnn_delegate_simulator - test_qnn_backend_runtime_option_heap_profile (executorch.backends.qualcomm.tests.fb.test_qnn_delegate_simulator.TestQNNQuantizedUtilsSimulator)'
buck test @fbcode//mode/dev fbcode//executorch/backends/qualcomm/tests/fb:test_qnn_delegate_simulator -- --exact 'fbcode//executorch/backends/qualcomm/tests/fb:test_qnn_delegate_simulator - test_qnn_backend_runtime_option_heap_profile (executorch.backends.qualcomm.tests.fb.test_qnn_delegate_simulator.TestQNNFloatingPointUtilsSimulator)'