Skip to content

Handle out_dtype in ReplacePT2DequantWithCadenceDequantPass (#19743)#19743

Open
ethansfng wants to merge 1 commit into
pytorch:mainfrom
ethansfng:export-D105630451
Open

Handle out_dtype in ReplacePT2DequantWithCadenceDequantPass (#19743)#19743
ethansfng wants to merge 1 commit into
pytorch:mainfrom
ethansfng:export-D105630451

Conversation

@ethansfng
Copy link
Copy Markdown
Contributor

@ethansfng ethansfng commented May 22, 2026

Summary:

torchao's convert_pt2e adds out_dtype kwargs to dequant nodes for bf16 models. cadence::dequantize_per_tensor doesn't support this kwarg (it hardcodes float32 output), so ReplacePT2DequantWithCadenceDequantPass crashes when it forwards kwargs blindly to the cadence op.

Strip out_dtype from kwargs before creating the cadence dequant node, and insert an aten.to.dtype cast after it to preserve the original output dtype semantics.

Differential Revision: D105630451

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 22, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19743

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit fa1bce3 with merge base ec76470 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 22, 2026

@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105630451.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…19743)

Summary:

torchao's `convert_pt2e` adds `out_dtype` kwargs to dequant nodes for bf16 models. `cadence::dequantize_per_tensor` doesn't support this kwarg (it hardcodes float32 output), so `ReplacePT2DequantWithCadenceDequantPass` crashes when it forwards kwargs blindly to the cadence op.

Strip `out_dtype` from kwargs before creating the cadence dequant node, and insert an `aten.to.dtype` cast after it to preserve the original output dtype semantics.

Differential Revision: D105630451
@meta-codesync meta-codesync Bot changed the title Handle out_dtype in ReplacePT2DequantWithCadenceDequantPass Handle out_dtype in ReplacePT2DequantWithCadenceDequantPass (#19743) May 23, 2026
@ethansfng ethansfng force-pushed the export-D105630451 branch from 50f7925 to fa1bce3 Compare May 23, 2026 00:30
ethansfng added a commit to ethansfng/executorch that referenced this pull request May 23, 2026
…19743)

Summary:

torchao's `convert_pt2e` adds `out_dtype` kwargs to dequant nodes for bf16 models. `cadence::dequantize_per_tensor` doesn't support this kwarg (it hardcodes float32 output), so `ReplacePT2DequantWithCadenceDequantPass` crashes when it forwards kwargs blindly to the cadence op.

Strip `out_dtype` from kwargs before creating the cadence dequant node, and insert an `aten.to.dtype` cast after it to preserve the original output dtype semantics.

Differential Revision: D105630451
ethansfng added a commit to ethansfng/executorch that referenced this pull request May 23, 2026
…19743)

Summary:

torchao's `convert_pt2e` adds `out_dtype` kwargs to dequant nodes for bf16 models. `cadence::dequantize_per_tensor` doesn't support this kwarg (it hardcodes float32 output), so `ReplacePT2DequantWithCadenceDequantPass` crashes when it forwards kwargs blindly to the cadence op.

Strip `out_dtype` from kwargs before creating the cadence dequant node, and insert an `aten.to.dtype` cast after it to preserve the original output dtype semantics.

Differential Revision: D105630451
ethansfng added a commit to ethansfng/executorch that referenced this pull request May 23, 2026
…19743)

Summary:

torchao's `convert_pt2e` adds `out_dtype` kwargs to dequant nodes for bf16 models. `cadence::dequantize_per_tensor` doesn't support this kwarg (it hardcodes float32 output), so `ReplacePT2DequantWithCadenceDequantPass` crashes when it forwards kwargs blindly to the cadence op.

Strip `out_dtype` from kwargs before creating the cadence dequant node, and insert an `aten.to.dtype` cast after it to preserve the original output dtype semantics.

Differential Revision: D105630451
ethansfng added a commit to ethansfng/executorch that referenced this pull request May 23, 2026
…19743)

Summary:

torchao's `convert_pt2e` adds `out_dtype` kwargs to dequant nodes for bf16 models. `cadence::dequantize_per_tensor` doesn't support this kwarg (it hardcodes float32 output), so `ReplacePT2DequantWithCadenceDequantPass` crashes when it forwards kwargs blindly to the cadence op.

Strip `out_dtype` from kwargs before creating the cadence dequant node, and insert an `aten.to.dtype` cast after it to preserve the original output dtype semantics.

Differential Revision: D105630451
ethansfng added a commit to ethansfng/executorch that referenced this pull request May 23, 2026
…19743)

Summary:

torchao's `convert_pt2e` adds `out_dtype` kwargs to dequant nodes for bf16 models. `cadence::dequantize_per_tensor` doesn't support this kwarg (it hardcodes float32 output), so `ReplacePT2DequantWithCadenceDequantPass` crashes when it forwards kwargs blindly to the cadence op.

Strip `out_dtype` from kwargs before creating the cadence dequant node, and insert an `aten.to.dtype` cast after it to preserve the original output dtype semantics.

Differential Revision: D105630451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant