Add extension_llm_runner to CMake deps (#19749)#19749
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19749
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 3 Pending, 1 Unclassified FailureAs of commit 24eafde with merge base 7d8063f ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@kirklandsign has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106162684. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR fixes link-time build failures for the ASR runner extension by adding the missing CMake link dependency on extension_llm_runner, which provides implementations used by transducer_runner.cpp (via llm_runner_helper.h).
Changes:
- Add
extension_llm_runnertoextension_asr_runner’srunner_depsso the ASR runner links the required LLM runner helper implementations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -22,7 +22,7 @@ endif() | |||
| include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake) | |||
|
|
|||
Summary: transducer_runner.cpp includes llm_runner_helper.h and uses load_tokenizer(), time_in_ms(), and print_report() which are implemented in extension_llm_runner. Without this link dependency, builds fail with undefined symbol errors. Reviewed By: Gasoonjia Differential Revision: D106162684
198f97e to
24eafde
Compare
Summary:
transducer_runner.cpp includes llm_runner_helper.h and uses
load_tokenizer(), time_in_ms(), and print_report() which are
implemented in extension_llm_runner. Without this link dependency,
builds fail with undefined symbol errors.
Reviewed By: Gasoonjia
Differential Revision: D106162684