Skip to content

Add extension_llm_runner to CMake deps (#19749)#19749

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
export-D106162684
May 23, 2026
Merged

Add extension_llm_runner to CMake deps (#19749)#19749
meta-codesync[bot] merged 1 commit into
mainfrom
export-D106162684

Conversation

@kirklandsign
Copy link
Copy Markdown
Contributor

@kirklandsign kirklandsign commented May 23, 2026

Summary:

transducer_runner.cpp includes llm_runner_helper.h and uses
load_tokenizer(), time_in_ms(), and print_report() which are
implemented in extension_llm_runner. Without this link dependency,
builds fail with undefined symbol errors.

Reviewed By: Gasoonjia

Differential Revision: D106162684

Copilot AI review requested due to automatic review settings May 23, 2026 04:14
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19749

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Pending, 1 Unclassified Failure

As of commit 24eafde with merge base 7d8063f (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • Check Labels / Check labels (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    RuntimeError: GraphQL query

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 23, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 23, 2026

@kirklandsign has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106162684.

@github-actions
Copy link
Copy Markdown

ghost commented May 23, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes link-time build failures for the ASR runner extension by adding the missing CMake link dependency on extension_llm_runner, which provides implementations used by transducer_runner.cpp (via llm_runner_helper.h).

Changes:

  • Add extension_llm_runner to extension_asr_runner’s runner_deps so the ASR runner links the required LLM runner helper implementations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -22,7 +22,7 @@ endif()
include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)

Summary:

transducer_runner.cpp includes llm_runner_helper.h and uses
load_tokenizer(), time_in_ms(), and print_report() which are
implemented in extension_llm_runner. Without this link dependency,
builds fail with undefined symbol errors.

Reviewed By: Gasoonjia

Differential Revision: D106162684
@meta-codesync meta-codesync Bot changed the title Add extension_llm_runner to CMake deps Add extension_llm_runner to CMake deps (#19749) May 23, 2026
@meta-codesync meta-codesync Bot force-pushed the export-D106162684 branch from 198f97e to 24eafde Compare May 23, 2026 16:18
@meta-codesync meta-codesync Bot merged commit d757776 into main May 23, 2026
331 of 376 checks passed
@meta-codesync meta-codesync Bot deleted the export-D106162684 branch May 23, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants