Skip to content

Arm backend: Add BF16 layer tests for Qwen#19767

Merged
tom-arm merged 3 commits into
pytorch:mainfrom
tom-arm:add_qwen_bf16_tests
May 29, 2026
Merged

Arm backend: Add BF16 layer tests for Qwen#19767
tom-arm merged 3 commits into
pytorch:mainfrom
tom-arm:add_qwen_bf16_tests

Conversation

@tom-arm
Copy link
Copy Markdown
Collaborator

@tom-arm tom-arm commented May 26, 2026

  • Add layers that run in BF16 in the HF model

Change-Id: If75434db138059f3a433a70abda3f3e26f6dd3b6

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

* Add layers that run in BF16 in the HF model

Signed-off-by: Tom Allsop <tom.allsop@arm.com>
Change-Id: If75434db138059f3a433a70abda3f3e26f6dd3b6
Copilot AI review requested due to automatic review settings May 26, 2026 09:11
@tom-arm tom-arm requested a review from digantdesai as a code owner May 26, 2026 09:11
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19767

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Unrelated Failures

As of commit e698083 with merge base c505aa5 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2026
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 26, 2026

CLA Not Signed

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds BF16 coverage for selected Qwen3-VL layer-level TOSA FP tests in the Arm backend test suite, to better reflect layers that execute in BF16 in the upstream HuggingFace model.

Changes:

  • Introduces a helper to cast a model and its floating-point inputs to torch.bfloat16.
  • Adds a curated TOSA_BF16_TEST_CASES subset and a new parameterized BF16 TOSA FP test invoking the pipeline with tosa_extensions=["bf16"] and custom tolerances.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backends/arm/test/models/Qwen3_VL/test_qwen3_vl_layers.py
Comment thread backends/arm/test/models/Qwen3_VL/test_qwen3_vl_layers.py
@tom-arm tom-arm added the release notes: none Do not include this in the release notes label May 26, 2026
tom-arm and others added 2 commits May 28, 2026 11:21
Signed-off-by: Tom Allsop <tom.allsop@arm.com>
Change-Id: I5ad74cc3d108b4c1f441570182b3f849d5fe1a9f
Copilot AI review requested due to automatic review settings May 28, 2026 10:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@tom-arm
Copy link
Copy Markdown
Collaborator Author

tom-arm commented May 29, 2026

Failures unrelated

@tom-arm tom-arm merged commit ea37954 into pytorch:main May 29, 2026
459 of 465 checks passed
@tom-arm tom-arm deleted the add_qwen_bf16_tests branch May 29, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants