Skip to content

Arm backend: Relocate not-equal decomposition after rank matching#19769

Merged
Sebastian-Larsson merged 2 commits into
pytorch:mainfrom
Sebastian-Larsson:relocate_ne_decomp_pass
May 27, 2026
Merged

Arm backend: Relocate not-equal decomposition after rank matching#19769
Sebastian-Larsson merged 2 commits into
pytorch:mainfrom
Sebastian-Larsson:relocate_ne_decomp_pass

Conversation

@Sebastian-Larsson
Copy link
Copy Markdown
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented May 26, 2026

Move DecomposeNotEqualPass to the post scalar-removal node transformation block. This removes its special placement between ReplaceScalarWithTensorByProfilePass and MatchArgRanksPass.

Also match ranks for ne.Tensor before decomposition so scalar not-equal does not produce mismatched TOSA EQUAL operands.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell @rascani

Move DecomposeNotEqualPass to the post scalar-removal node
transformation block. This removes its special placement between
ReplaceScalarWithTensorByProfilePass and MatchArgRanksPass.

Also match ranks for ne.Tensor before decomposition so scalar
not-equal does not produce mismatched TOSA EQUAL operands.

Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Change-Id: I131e617a4625f5cd9c28c553af44cd2276803d94
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels May 26, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19769

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (4 Unrelated Failures)

As of commit 211f988 with merge base 77df9b7 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2026
@github-actions github-actions Bot added the module: arm Issues related to arm backend label May 27, 2026
@Sebastian-Larsson Sebastian-Larsson merged commit 4741f3a into pytorch:main May 27, 2026
457 of 465 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants