Skip to content

Fix TrainingModule class declaration formatting#19830

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
export-D106574405
May 27, 2026
Merged

Fix TrainingModule class declaration formatting#19830
meta-codesync[bot] merged 1 commit into
mainfrom
export-D106574405

Conversation

@kirklandsign
Copy link
Copy Markdown
Contributor

Summary: Reformat TrainingModule class declaration to place private constructor on the same line as the class name, with Closeable wrapping to the next line. This follows the standard Kotlin formatting convention.

Differential Revision: D106574405

Summary: Reformat `TrainingModule` class declaration to place `private constructor` on the same line as the class name, with `Closeable` wrapping to the next line. This follows the standard Kotlin formatting convention.

Differential Revision: D106574405
Copilot AI review requested due to automatic review settings May 27, 2026 22:58
@kirklandsign kirklandsign requested a review from psiddh as a code owner May 27, 2026 22:58
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19830

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 19 Pending

As of commit 6e9cf5b with merge base d366f43 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 27, 2026

@kirklandsign has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106574405.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts Kotlin formatting for the TrainingModule class declaration in the Android training wrapper to better match standard Kotlin style (placing the private constructor on the same line as the class name and wrapping the Closeable supertype onto the next line).

Changes:

  • Reformats the TrainingModule class header to keep class ... private constructor(...) on one line.
  • Wraps the : Closeable portion onto a continuation line with consistent indentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meta-codesync meta-codesync Bot merged commit 53fa4dd into main May 27, 2026
180 of 186 checks passed
@meta-codesync meta-codesync Bot deleted the export-D106574405 branch May 27, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants