Skip to content

Add ASR module and LoRA/dataFiles instrumentation tests#19859

Merged
psiddh merged 2 commits into
pytorch:mainfrom
psiddh:asr-lora-instrumentation-tests
May 29, 2026
Merged

Add ASR module and LoRA/dataFiles instrumentation tests#19859
psiddh merged 2 commits into
pytorch:mainfrom
psiddh:asr-lora-instrumentation-tests

Conversation

@psiddh
Copy link
Copy Markdown
Contributor

@psiddh psiddh commented May 28, 2026

Adds two new Android instrumentation test suites covering previously untested API surfaces, completing feature testing coverage for OKR 3.2.

AsrModuleInstrumentationTest (18 tests): constructor validation, lifecycle (close idempotency, use-after-close), transcribe validation, and AsrTranscribeConfig builder/validation.

LlmLoraInstrumentationTest (13 tests): dataFiles constructor variants, LlmModuleConfig with dataPath, invalid data file error handling, baseline equivalence, and config builder validation.

Test plan

  • ./gradlew :executorch_android:connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=org.pytorch.executor ch.AsrModuleInstrumentationTest
  • ./gradlew :executorch_android:connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=org.pytorch.executor ch.LlmLoraInstrumentationTest
  • Verify all 31 new tests pass on emulator (API 34 x86_64)
  • Verify existing tests are unaffected

Copilot AI review requested due to automatic review settings May 28, 2026 20:39
@psiddh psiddh requested a review from kirklandsign as a code owner May 28, 2026 20:39
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 28, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19859

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 28, 2026
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 28, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: psiddh / name: Siddartha Pothapragada (70bcbaf)

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh psiddh force-pushed the asr-lora-instrumentation-tests branch from 32e57a7 to 70bcbaf Compare May 28, 2026 20:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds two new Android instrumentation test suites under extension/android/executorch_android/src/androidTest/ to cover previously untested API surfaces: AsrModule / AsrTranscribeConfig / AsrCallback, and LlmModule's LoRA / dataFiles constructor variants together with LlmModuleConfig validation. No production code is modified. The tests rely on the existing TinyStories .pte and tokenizer test fixtures provisioned by android_test_setup.sh.

Changes:

  • Adds AsrModuleInstrumentationTest.kt covering ASR constructor/path validation, lifecycle (close idempotency, use-after-close), transcribe input validation, and AsrTranscribeConfig builder/equality/validation.
  • Adds LlmLoraInstrumentationTest.kt covering LlmModule dataFiles/dataPath constructor variants, LlmModuleConfig dataPath / loadMode integration, invalid data-file error handling, baseline equivalence with the no-data constructor, and config builder validation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
extension/android/executorch_android/src/androidTest/java/org/pytorch/executorch/AsrModuleInstrumentationTest.kt New instrumentation tests for AsrModule, lifecycle, and AsrTranscribeConfig.
extension/android/executorch_android/src/androidTest/java/org/pytorch/executorch/LlmLoraInstrumentationTest.kt New instrumentation tests for LlmModule dataFiles/dataPath constructors and LlmModuleConfig builder.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@psiddh psiddh requested a review from GregoryComer May 28, 2026 20:45
@psiddh psiddh force-pushed the asr-lora-instrumentation-tests branch from f45ae38 to 396b525 Compare May 28, 2026 20:54
Copilot AI review requested due to automatic review settings May 28, 2026 23:49
@psiddh psiddh force-pushed the asr-lora-instrumentation-tests branch from 396b525 to bb3b996 Compare May 28, 2026 23:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Adds two new Android instrumentation test suites covering previously
untested API surfaces, completing feature testing coverage for OKR 3.2.

AsrModuleInstrumentationTest (18 tests): constructor validation, lifecycle
(close idempotency, use-after-close), transcribe validation, and
AsrTranscribeConfig builder/validation.

LlmLoraInstrumentationTest (13 tests): dataFiles constructor variants,
LlmModuleConfig with dataPath, invalid data file error handling, baseline
equivalence, and config builder validation.
@psiddh psiddh force-pushed the asr-lora-instrumentation-tests branch from d8d0edc to 2eedd0c Compare May 29, 2026 00:21
@psiddh psiddh merged commit 9596866 into pytorch:main May 29, 2026
160 of 162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants