Add ASR module and LoRA/dataFiles instrumentation tests#19859
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19859
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
This PR needs a
|
32e57a7 to
70bcbaf
Compare
There was a problem hiding this comment.
Pull request overview
Adds two new Android instrumentation test suites under extension/android/executorch_android/src/androidTest/ to cover previously untested API surfaces: AsrModule / AsrTranscribeConfig / AsrCallback, and LlmModule's LoRA / dataFiles constructor variants together with LlmModuleConfig validation. No production code is modified. The tests rely on the existing TinyStories .pte and tokenizer test fixtures provisioned by android_test_setup.sh.
Changes:
- Adds
AsrModuleInstrumentationTest.ktcovering ASR constructor/path validation, lifecycle (close idempotency, use-after-close), transcribe input validation, andAsrTranscribeConfigbuilder/equality/validation. - Adds
LlmLoraInstrumentationTest.ktcoveringLlmModuledataFiles/dataPathconstructor variants,LlmModuleConfigdataPath/loadModeintegration, invalid data-file error handling, baseline equivalence with the no-data constructor, and config builder validation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| extension/android/executorch_android/src/androidTest/java/org/pytorch/executorch/AsrModuleInstrumentationTest.kt | New instrumentation tests for AsrModule, lifecycle, and AsrTranscribeConfig. |
| extension/android/executorch_android/src/androidTest/java/org/pytorch/executorch/LlmLoraInstrumentationTest.kt | New instrumentation tests for LlmModule dataFiles/dataPath constructors and LlmModuleConfig builder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f45ae38 to
396b525
Compare
396b525 to
bb3b996
Compare
Adds two new Android instrumentation test suites covering previously untested API surfaces, completing feature testing coverage for OKR 3.2. AsrModuleInstrumentationTest (18 tests): constructor validation, lifecycle (close idempotency, use-after-close), transcribe validation, and AsrTranscribeConfig builder/validation. LlmLoraInstrumentationTest (13 tests): dataFiles constructor variants, LlmModuleConfig with dataPath, invalid data file error handling, baseline equivalence, and config builder validation.
d8d0edc to
2eedd0c
Compare
Adds two new Android instrumentation test suites covering previously untested API surfaces, completing feature testing coverage for OKR 3.2.
AsrModuleInstrumentationTest (18 tests): constructor validation, lifecycle (close idempotency, use-after-close), transcribe validation, and AsrTranscribeConfig builder/validation.
LlmLoraInstrumentationTest (13 tests): dataFiles constructor variants, LlmModuleConfig with dataPath, invalid data file error handling, baseline equivalence, and config builder validation.
Test plan
./gradlew :executorch_android:connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=org.pytorch.executor ch.AsrModuleInstrumentationTest./gradlew :executorch_android:connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.class=org.pytorch.executor ch.LlmLoraInstrumentationTest