Move edge manager copy inside the generate_etrecord flag check #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2437
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 43304c3 with merge base a5faf03 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54919118 |
…h#2437) Summary: right now making a blind copy of edge manager blows up the memory usage of export 🥲 Differential Revision: D54919118
Olivia-liu
force-pushed
the
export-D54919118
branch
from
0a52f48 to
43304c3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54919118 |
lucylq
approved these changes
Mar 14, 2024
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Mar 15, 2024
…h#2437) Summary: right now making a blind copy of edge manager blows up the memory usage of export 🥲 Reviewed By: lucylq Differential Revision: D54919118
Contributor
|
This pull request has been merged in dae670e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: right now making a blind copy of edge manager blows up the memory usage of export 🥲
Differential Revision: D54919118