move get tokenizer to export_llama_lib #4451
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D60419366](https://our.internmc.facebook.com/intern/diff/D60419366/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4451
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ea35005 with merge base a743a3b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60419366 |
Differential Revision: [D60419366](https://our.internmc.facebook.com/intern/diff/D60419366/) [ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jul 30, 2024
Pull Request resolved: #4451 ghstack-source-id: 235856034 @exported-using-ghexport Differential Revision: [D60419366](https://our.internmc.facebook.com/intern/diff/D60419366/)
|
This pull request was exported from Phabricator. Differential Revision: D60419366 |
larryliu0820
approved these changes
Jul 30, 2024
Differential Revision: [D60419366](https://our.internmc.facebook.com/intern/diff/D60419366/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60419366 |
Differential Revision: [D60419366](https://our.internmc.facebook.com/intern/diff/D60419366/) [ghstack-poisoned]
Closed
|
This pull request was exported from Phabricator. Differential Revision: D60419366 |
Differential Revision: [D60419366](https://our.internmc.facebook.com/intern/diff/D60419366/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60419366 |
|
This pull request has been merged in d207eb0. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Move the get tokenizer logic to export_llama_lib so we can use it during export as well. It's needed in the second diff when to run pt2e for calibration Pull Request resolved: pytorch/executorch#4451 ghstack-source-id: 236234068 @exported-using-ghexport Differential Revision: [D60419366](https://our.internmc.facebook.com/intern/diff/D60419366/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D60419366