Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions examples/models/llama2/eval_llama_lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from executorch.extension.llm.tokenizer.tokenizer import (
Tokenizer as SentencePieceTokenizer,
)

from executorch.extension.llm.tokenizer.utils import get_tokenizer
from lm_eval.api.model import LM

from .export_llama_lib import (
Expand Down Expand Up @@ -103,11 +103,7 @@ def gen_eval_wrapper(
Returns:
eval_wrapper (LM): A wrapper interface for the lm-evaluation-harness library.
"""
try:
tokenizer = SentencePieceTokenizer(model_path=str(args.tokenizer_path))
except Exception:
print("Using Tiktokenizer")
tokenizer = Tiktoken(model_path=str(args.tokenizer_path))
tokenizer = get_tokenizer(args.tokenizer_path)

# ExecuTorch Binary Evaluation
if (model := args.pte) is not None:
Expand Down
21 changes: 21 additions & 0 deletions extension/llm/tokenizer/targets.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,27 @@ def define_common_targets():
],
)

runtime.python_library(
name = "utils",
srcs = [
"utils.py",
],
base_module = "executorch.extension.llm.utils",
visibility = [
"//executorch/examples/...",
"//executorch/extension/llm/tokenizer/...",
"//bento/...",
"//bento_kernels/...",
],
deps = [
"//executorch/examples/models/llama2/tokenizer:tiktoken",
],
_is_external_target = True,
external_deps = [
"sentencepiece-py",
],
)

runtime.python_binary(
name = "tokenizer_py",
main_module = "executorch.extension.llm.tokenizer.tokenizer",
Expand Down
20 changes: 20 additions & 0 deletions extension/llm/tokenizer/utils.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.

# pyre-ignore: Undefined import [21]: Could not find a module corresponding to import `executorch.examples.models.llama2.tokenizer.tiktoken`.
from executorch.examples.models.llama2.tokenizer.tiktoken import Tokenizer as Tiktoken
from executorch.extension.llm.tokenizer.tokenizer import (
Tokenizer as SentencePieceTokenizer,
)


def get_tokenizer(tokenizer_path):
try:
tokenizer = SentencePieceTokenizer(model_path=str(tokenizer_path))
except Exception:
print("Using Tiktokenizer")
tokenizer = Tiktoken(model_path=str(tokenizer_path))
return tokenizer