Skip to content

Skip storing unnecessary metadata in ManagedTensor. #4572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Aug 11, 2024
Merged

Skip storing unnecessary metadata in ManagedTensor. #4572

facebook-github-bot merged 1 commit into from
Aug 11, 2024

Conversation

@shoumikhin
Copy link
Contributor

@shoumikhin shoumikhin commented Aug 6, 2024

Summary: Only the sizes array is needed looks like.

Differential Revision: D60854858

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4572

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d0f4067 with merge base 18b829c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 6, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 6, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 6, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

6 similar comments
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 6, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 7, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 7, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 7, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

@shoumikhin @facebook-github-bot
Skip storing unnecessary metadata in ManagedTensor. (#4572)
d0f4067 
Summary:
Pull Request resolved: #4572

Only the sizes array is needed looks like.
Also, remove dependency on ManagedTensor from aten conversion tool.

Reviewed By: kirklandsign

Differential Revision: D60854858
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2024

This pull request was exported from Phabricator. Differential Revision: D60854858

@facebook-github-bot facebook-github-bot merged commit 99e1ae1 into pytorch:main Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shoumikhin @facebook-github-bot