Skip to content

Conversation

@haowhsu-quic
Copy link
Collaborator

Summary:

  • add compile option for pybind (fexceptions)
  • prevent linking sanitizer in flatcc
  • force rebuild flatcc when invoke "build.sh --no_clean"

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4625

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 45583bc with merge base 98b8ae1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Aug 9, 2024

Hey can we rebase? Looks like conflict with #4590

Summary:
- add compile option for pybind (fexceptions)
- prevent linking sanitizer in flatcc
- force rebuild flatcc when invoke "build.sh --no_clean"
@haowhsu-quic haowhsu-quic force-pushed the dev_enable_release_build branch from fcf1117 to 45583bc Compare August 10, 2024 03:08
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 7f34796 into pytorch:main Aug 10, 2024
5 checks passed
@haowhsu-quic haowhsu-quic deleted the dev_enable_release_build branch February 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants