Skip to content

Fix periodic run and model name for benchmarking #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Aug 12, 2024
Merged

Fix periodic run and model name for benchmarking #4642

facebook-github-bot merged 1 commit into from
Aug 12, 2024

Conversation

@guangy10
Copy link
Contributor

@guangy10 guangy10 commented Aug 9, 2024

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4642

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7a0cf93 with merge base 9b2bfb6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2024
@guangy10 guangy10 force-pushed the fixes_in_android_perf branch from 9347722 to 27dca26 Compare August 9, 2024 20:44
huydhn
huydhn reviewed Aug 9, 2024
View reviewed changes
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 9, 2024

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@huydhn huydhn mentioned this pull request Aug 10, 2024
Merged
@guangy10 guangy10 force-pushed the fixes_in_android_perf branch from 5d91be1 to ae7747f Compare August 12, 2024 17:28
@guangy10
Copy link
Contributor Author

guangy10 commented Aug 12, 2024

#4657 has merged. Testing e2e on PR..

@guangy10 guangy10 force-pushed the fixes_in_android_perf branch from ae7747f to 3071c24 Compare August 12, 2024 20:24
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 12, 2024

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor Author

guangy10 commented Aug 12, 2024

UI dispatched job: https://github.com/pytorch/executorch/actions/runs/10359032104/job/28675748707
PR (mimic periodic) job: https://github.com/pytorch/executorch/actions/runs/10358842400/job/28675321782?pr=4642

Both are finished successfully

@guangy10 guangy10 force-pushed the fixes_in_android_perf branch from 3071c24 to 7a0cf93 Compare August 12, 2024 23:02
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 12, 2024

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit b6de6ed into main Aug 12, 2024
@guangy10 guangy10 deleted the fixes_in_android_perf branch August 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

@huydhn huydhn huydhn approved these changes

@kit1980 kit1980 Awaiting requested review from kit1980

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guangy10 @facebook-github-bot @huydhn @kirklandsign