Skip to content

Use pread() in FileDataLoader. #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

Use pread() in FileDataLoader. #4760

merged 1 commit into from
Aug 21, 2024

Conversation

@shoumikhin
Copy link
Contributor

@shoumikhin shoumikhin commented Aug 16, 2024

Summary: Allow reading from multiple threads simultaneously.

Reviewed By: dbort

Differential Revision: D61408840

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4760

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b1f8201 with merge base 055af09 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 16, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 16, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

10 similar comments
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 19, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 20, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 20, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 20, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 20, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@shoumikhin @facebook-github-bot
Use pread() in FileDataLoader. (#4760)
b1f8201 
Summary:
Pull Request resolved: #4760

Allow reading from multiple threads simultaneously.

Reviewed By: dbort, hsharma35

Differential Revision: D61408840
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 21, 2024

This pull request was exported from Phabricator. Differential Revision: D61408840

@facebook-github-bot facebook-github-bot merged commit ccd684f into pytorch:main Aug 21, 2024
@dbort dbort mentioned this pull request Aug 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbort dbort dbort approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shoumikhin @facebook-github-bot @dbort