Clean up install scripts #4826
Merged
Clean up install scripts #4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4826
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bed6b96 with merge base ce4917c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
force-pushed
the
lfq.clean-install-scripts
branch
2 times, most recently
from
481201d to
bad7fc4
Compare
lucylq
force-pushed
the
lfq.clean-install-scripts
branch
from
bad7fc4 to
bed6b96
Compare
|
@lucylq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
Aug 23, 2024
dbort
approved these changes
Aug 23, 2024
huydhn
added a commit
that referenced
this pull request
Jan 9, 2025
huydhn
added a commit
that referenced
this pull request
Jan 9, 2025
huydhn
added a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that setup-macos.sh and setup-linux.sh are using install_requirements, we can remove installing flatc from source, pytorch and pytorch domains install from them.