Input name bugfix in runner_utils #5071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5071
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 00bbb78 with merge base d516309 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
digantdesai
approved these changes
Sep 5, 2024
| f.write(tosa_fb) | ||
|
|
||
| tosa_schema_file = "./backends/arm/third-party/serialization_lib/schema/tosa.fbs" | ||
| arm_backend_path = os.path.realpath(os.path.dirname(__file__) + "/..") |
Collaborator
Author
There was a problem hiding this comment.
Yes it's unrelated, I should probably have added several commits to the the PR for clarity
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Erik-Lundell
force-pushed
the
input-name-bugfix
branch
from
8a4a72a to
a37b788
Compare
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Apologies for the delay, can you please rebase this on main? Thanks. |
There are cases where the names of the inputs in the edge-IR graph do not match the names of the inputs in the export-IR. Since desc.json used the names from export-IR while TOSA used the names from edge-IR there was a mismatch. I therefore changed desc.json to use the names from edge-IR if possible. I also changed the search of tosa.fbs to be cwd independent. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Iffa56e2f43910adc74608b96518717d14e0beb53
Erik-Lundell
force-pushed
the
input-name-bugfix
branch
from
a37b788 to
00bbb78
Compare
Collaborator
Author
Delay from my side as well, but rebased now. |
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@digantdesai merged this pull request in 4bf7e2f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where the names of the inputs
in the edge-IR graph do not match the names of the inputs in the export-IR. Since desc.json used the names from export-IR while TOSA used the names from edge-IR there was a mismatch.
I therefore changed desc.json to use the names from edge-IR if possible. I also changed the search of tosa.fbs to be cwd independent, and added a check to avoid a crash if you .dump_artifact() on a graph with no delegate.
Change-Id: Iffa56e2f43910adc74608b96518717d14e0beb53