Use metal instance for Android emulator for KVM support#5127
Merged
facebook-github-bot merged 1 commit intomainfrom Sep 7, 2024
Merged
Use metal instance for Android emulator for KVM support#5127facebook-github-bot merged 1 commit intomainfrom
facebook-github-bot merged 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5127
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e693f5c with merge base 8afdc48 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@huydhn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kirklandsign
approved these changes
Sep 6, 2024
Summary: A known issue when running Android emulator test on our Linux runner is that the runner, already a virtual machine, doesn't support KVM/hardware accelerator, for example https://github.com/pytorch/executorch/actions/runs/10732304130/job/29764671347#step:9:37. The drawback is that it takes longer to emulate anything there. There are some metal Linux runners around in our infra that folks uses for CPU benchmarking. I think we can try to use them as there are still spare capacity and the current Android emulator test is relatively fast. ### Testing The current emulator job takes around 7 to 10m https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=emulator After running on metal instance, it takes https://github.com/pytorch/executorch/actions/runs/10732098391/job/29764069309?pr=5127, the emulator job takes around 2m Pull Request resolved: #5127 Reviewed By: kirklandsign Differential Revision: D62299612 Pulled By: huydhn
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62299612 |
huydhn
force-pushed
the
run-android-emulator-on-metal
branch
from
731214d to
e693f5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A known issue when running Android emulator test on our Linux runner is that the runner, already a virtual machine, doesn't support KVM/hardware accelerator, for example https://github.com/pytorch/executorch/actions/runs/10732304130/job/29764671347#step:9:37. It means that emulating anything takes longer.
There are some metal Linux runners around in our infra that folks uses for CPU benchmarking. I think we can try to use them as there are still spare capacity and the current Android emulator job is relatively small to squeeze in. AWS metal runners are "real" and supports KVM.
Testing
The current emulator job takes around 7 to 10m https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=emulator
After running on metal instance, it takes https://github.com/pytorch/executorch/actions/runs/10732098391/job/29764069309?pr=5127, the emulator job takes around 2m