Restore constant segment #5141
Merged
Restore constant segment #5141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5141
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1eb730a with merge base b69ae0c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62278416 |
dbort
approved these changes
Sep 9, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62278416 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: pytorch#5141 Restore constant segment in deserialize_pte_binary. Note that programs are not identical afterwards, as we do not store the size of the constant buffer. Instead, the restored program will contain tensor+padding in each buffer. Reviewed By: dbort Differential Revision: D62278416
lucylq
force-pushed
the
export-D62278416
branch
from
5982e2f to
36aea65
Compare
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: pytorch#5141 Restore constant segment in deserialize_pte_binary. Note that programs are not identical afterwards, as we do not store the size of the constant buffer. Instead, the restored program will contain tensor+padding in each buffer. Reviewed By: dbort Differential Revision: D62278416
lucylq
force-pushed
the
export-D62278416
branch
from
36aea65 to
a4c7790
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62278416 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62278416 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: pytorch#5141 Restore constant segment in deserialize_pte_binary. Note that programs are not identical afterwards, as we do not store the size of the constant buffer. Instead, the restored program will contain tensor+padding in each buffer. Reviewed By: dbort Differential Revision: D62278416
lucylq
force-pushed
the
export-D62278416
branch
from
a4c7790 to
2b524aa
Compare
Summary: Pull Request resolved: pytorch#5141 Restore constant segment in deserialize_pte_binary. Note that programs are not identical afterwards, as we do not store the size of the constant buffer. Instead, the restored program will contain tensor+padding in each buffer. Reviewed By: dbort Differential Revision: D62278416
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62278416 |
lucylq
force-pushed
the
export-D62278416
branch
from
2b524aa to
1eb730a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Restore constant segment in deserialize_pte_binary.
Note that programs are not identical afterwards, as we do not store the size of the constant buffer. Instead, the restored program will contain tensor+padding in each buffer.
Differential Revision: D62278416