Fix Hard Fault in arm_executor_runner #5302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The introduction of the PlatformMemoryAllocator in pytorch#5121 introduced a hard fault in arm_executor_runner when not supplying the temp_allocator in the MemoryManager, so add it to get tests running again. Signed-off-by: Per Åstrand <per.astrand@arm.com> Change-Id: I357244a15c1b1fdee567ad828e09e3607e43e2e7
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5302
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 0c9d78b with merge base 623b7b6 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
per
added
partner: arm
digantdesai
reviewed
Sep 12, 2024
|
|
||
| torch::executor::MemoryManager memory_manager( | ||
| &method_allocator, &planned_memory); | ||
| &method_allocator, &planned_memory, &temp_allocator); |
Contributor
There was a problem hiding this comment.
@manuelcandales shouldn't we fall back to using method allocator if null?
digantdesai
approved these changes
Sep 12, 2024
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
stamping to unbreak CI
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
manuelcandales
approved these changes
Sep 12, 2024
Contributor
|
@digantdesai merged this pull request in c032194. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of the PlatformMemoryAllocator in #5121 introduced a hard fault in arm_executor_runner when not supplying the temp_allocator in the MemoryManager, so add it to get tests running again.
Change-Id: I357244a15c1b1fdee567ad828e09e3607e43e2e7