[executorch] Add sdpa arg comments #5323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5323
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c1efb3e with merge base eb0cdf7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@dvorjackz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JacobSzwejbka
approved these changes
Sep 13, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: #5323 Reviewed By: JacobSzwejbka Differential Revision: D62623249 Pulled By: dvorjackz
facebook-github-bot
force-pushed
the
jackxz/comment-sdpa
branch
from
9f52b38 to
ea41fa9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62623249 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: #5323 Reviewed By: JacobSzwejbka Differential Revision: D62623249 Pulled By: dvorjackz
facebook-github-bot
force-pushed
the
jackxz/comment-sdpa
branch
from
ea41fa9 to
69bfe54
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62623249 |
Summary: Pull Request resolved: #5323 Reviewed By: JacobSzwejbka Differential Revision: D62623249 Pulled By: dvorjackz
facebook-github-bot
force-pushed
the
jackxz/comment-sdpa
branch
from
69bfe54 to
c1efb3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62623249 |
|
@dvorjackz merged this pull request in ef31608. |
lucylq
pushed a commit
that referenced
this pull request
Sep 17, 2024
Summary: Pull Request resolved: #5323 Reviewed By: JacobSzwejbka Differential Revision: D62623249 Pulled By: dvorjackz fbshipit-source-id: 468abd913a4dcb9b2474ec34881cfcec2654a024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.