[ET-VK] Enable tensor aliases with texture storage #5347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context Allow aliasing for `VulkanImage` objects, and by extension texture backed Tensors. Essentially just a re-application/extension of what was done in #4769. ghstack-source-id: 242310057 @exported-using-ghexport Differential Revision: [D62606929](https://our.internmc.facebook.com/intern/diff/D62606929/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5347
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc8843d with merge base 9845019 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62606929 |
SS-JIA
added a commit
that referenced
this pull request
Sep 13, 2024
## Context Allow aliasing for `VulkanImage` objects, and by extension texture backed Tensors. Essentially just a re-application/extension of what was done in #4769. ghstack-source-id: 242310057 exported-using-ghexport Differential Revision: [D62606929](https://our.internmc.facebook.com/intern/diff/D62606929/) ghstack-source-id: 242420878 Pull Request resolved: #5347
## Context Allow aliasing for `VulkanImage` objects, and by extension texture backed Tensors. Essentially just a re-application/extension of what was done in #4769. exported-using-ghexport Differential Revision: [D62606929](https://our.internmc.facebook.com/intern/diff/D62606929/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62606929 |
junpi3
approved these changes
Sep 13, 2024
junpi3
approved these changes
Sep 13, 2024
Contributor
|
This pull request has been merged in 25168b7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
virtual_transpose()tovTensorfor no copy transposition #5353Context
Allow aliasing for
VulkanImageobjects, and by extension texture backed Tensors.Essentially just a re-application/extension of what was done in #4769.
@exported-using-ghexport
Differential Revision: D62606929