Fix EValue construction from a smart pointer. #5357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5357
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6049c35 with merge base 67be84b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62658327 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62658327 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62658327 |
dbort
approved these changes
Sep 13, 2024
Summary: Pull Request resolved: #5357 The move constructor invoked by `*this =` expression tries to `destroy()` the `this` first, but it's not yet initialized. For example, if the tag is randomly `Tag::ListTensor`, `destroy()` will try to iterate over and destroy a list of tensors. But since the memory is uninitialized, it will typically crash or corrupt memory. Reviewed By: dbort Differential Revision: D62658327
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62658327 |
Contributor
|
This pull request has been merged in 0aa75e6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The move constructor invoked by
*this =expression tries todestroy()thethisfirst, but it's not yet initialized.Differential Revision: D62658327