Skip to content

[Android] Use ms for number report #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kirklandsign wants to merge 3 commits into from
Closed

[Android] Use ms for number report #5362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67d3478
[Android] Use ms for number report
kirklandsign Sep 13, 2024
6fa3f20
Double
kirklandsign Sep 13, 2024
11d53dd
ms
kirklandsign Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...droid/LlamaDemo/app/src/main/java/com/example/executorchllamademo/LlmBenchmarkRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@ public void onGenerationStopped() {
results.add(
new BenchmarkMetric(
benchmarkModel,
"model_load_time(ns)",
mStatsDump.loadEnd - mStatsDump.loadStart,
"model_load_time(ms)",
(mStatsDump.loadEnd - mStatsDump.loadStart) * 1e-6,
0.0f));
// LLM generate time
results.add(
new BenchmarkMetric(
benchmarkModel,
"generate_time(ns)",
mStatsDump.generateEnd - mStatsDump.generateStart,
"generate_time(ms)",
(mStatsDump.generateEnd - mStatsDump.generateStart) * 1e-6,
0.0f));
// Token per second
results.add(
Expand Down
8 changes: 4 additions & 4 deletions extension/android/benchmark/app/src/main/java/org/pytorch/minibench/BenchmarkActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ protected void onCreate(Bundle savedInstanceState) {
for (int i = 0; i < numIter; i++) {
long start = System.nanoTime();
module.forward();
long forwardMs = System.nanoTime() - start;
double forwardMs = (System.nanoTime() - start) * 1e-6;
stats.latency.add(forwardMs);
}

Expand All @@ -68,13 +68,13 @@ protected void onCreate(Bundle savedInstanceState) {
results.add(
new BenchmarkMetric(
benchmarkModel,
"avg_inference_latency(ns)",
"avg_inference_latency(ms)",
stats.latency.stream().mapToDouble(l -> l).average().orElse(0.0f),
0.0f));
// Model load time
results.add(
new BenchmarkMetric(
benchmarkModel, "model_load_time(ns)", stats.loadEnd - stats.loadStart, 0.0f));
benchmarkModel, "model_load_time(ms)", (stats.loadEnd - stats.loadStart) * 1e-6, 0.0f));
// Load status
results.add(new BenchmarkMetric(benchmarkModel, "load_status", stats.errorCode, 0));

Expand All @@ -90,7 +90,7 @@ protected void onCreate(Bundle savedInstanceState) {
class Stats {
long loadStart;
long loadEnd;
List<Long> latency = new ArrayList<>();
List<Double> latency = new ArrayList<>();
int errorCode = 0;

@Override
Expand Down
8 changes: 4 additions & 4 deletions ...nsion/android/benchmark/app/src/main/java/org/pytorch/minibench/LlmBenchmarkActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,15 @@ public void onGenerationStopped() {
results.add(
new BenchmarkMetric(
benchmarkModel,
"model_load_time(ns)",
mStatsInfo.loadEnd - mStatsInfo.loadStart,
"model_load_time(ms)",
(mStatsInfo.loadEnd - mStatsInfo.loadStart) * 1e-6,
0.0f));
// LLM generate time
results.add(
new BenchmarkMetric(
benchmarkModel,
"generate_time(ns)",
mStatsInfo.generateEnd - mStatsInfo.generateStart,
"generate_time(ms)",
(mStatsInfo.generateEnd - mStatsInfo.generateStart) * 1e-6,
0.0f));
// Token per second
results.add(
Expand Down