Migrate examples/apple/... away from the torch:: namespace #5405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5405
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 44fe6f5 with merge base c252553 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
shoumikhin
approved these changes
Sep 17, 2024
malfet
approved these changes
Sep 17, 2024
lucylq
pushed a commit
that referenced
this pull request
Sep 17, 2024
Summary: Migrate examples/apple/... to use the new `executorch::` namespace. Pull Request resolved: #5405 Test Plan: Build the examples using the instructions at - https://github.com/pytorch/executorch/blob/main/examples/apple/coreml/README.md - https://github.com/pytorch/executorch/blob/main/examples/apple/mps/README.md Reviewed By: malfet, shoumikhin Differential Revision: D62793645 Pulled By: dbort fbshipit-source-id: b74b95b8ae87eeae40e57b195351c841c4a90885
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Summary: Migrate examples/apple/... to use the new `executorch::` namespace. Pull Request resolved: #5405 Test Plan: Build the examples using the instructions at - https://github.com/pytorch/executorch/blob/main/examples/apple/coreml/README.md - https://github.com/pytorch/executorch/blob/main/examples/apple/mps/README.md Reviewed By: malfet, shoumikhin Differential Revision: D62793645 Pulled By: dbort fbshipit-source-id: b74b95b8ae87eeae40e57b195351c841c4a90885 (cherry picked from commit 5c3be4a)
Cherry picking #5405The cherry pick PR is at #5486 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Sep 20, 2024
Migrate examples/apple/... away from the torch:: namespace (#5405) Summary: Migrate examples/apple/... to use the new `executorch::` namespace. Pull Request resolved: #5405 Test Plan: Build the examples using the instructions at - https://github.com/pytorch/executorch/blob/main/examples/apple/coreml/README.md - https://github.com/pytorch/executorch/blob/main/examples/apple/mps/README.md Reviewed By: malfet, shoumikhin Differential Revision: D62793645 Pulled By: dbort fbshipit-source-id: b74b95b8ae87eeae40e57b195351c841c4a90885 (cherry picked from commit 5c3be4a) Co-authored-by: Dave Bort <dbort@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate examples/apple/... to use the new
executorch::namespace.Test Plan:
Build the examples using the instructions at