[ET-VK][BE][ez] vTensor cleanup 1/N - swap order of vTensor and vTensorStorage in cpp file
#5421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensorStorage` in cpp file ## Context TSIA; swap the order of `vTensorStorage` and `vTensor` function implementations in the `Tensor.cpp` file, such that it matches the order of declaration in the `Tensor.h` header file. I don't recall why the ordering was not consistent before. Differential Revision: [D62878648](https://our.internmc.facebook.com/intern/diff/D62878648/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5421
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 46e4184 with merge base e8a557c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62878648 |
This was referenced Sep 17, 2024
junpi3
approved these changes
Sep 17, 2024
|
This pull request has been merged in aaf73d8. |
lucylq
pushed a commit
that referenced
this pull request
Sep 17, 2024
… cpp file (#5421) Summary: Pull Request resolved: #5421 ## Context TSIA; swap the order of `vTensorStorage` and `vTensor` function implementations in the `Tensor.cpp` file, such that it matches the order of declaration in the `Tensor.h` header file. I don't recall why the ordering was not consistent before. ghstack-source-id: 243061029 exported-using-ghexport Reviewed By: jorgep31415 Differential Revision: D62878648 fbshipit-source-id: 4ac4d54bc8bc0d8aa30422e599e9605a7b351e33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
vectypes #5423discard_and_reallocateAPI #5422vTensorandvTensorStoragein cpp file #5421Context
TSIA; swap the order of
vTensorStorageandvTensorfunction implementations in theTensor.cppfile, such that it matches the order of declaration in theTensor.hheader file. I don't recall why the ordering was not consistent before.Differential Revision: D62878648