[ET-VK][BE] vTensor cleanup 5/N - clean up indexing_utils.h and clarify function names
#5443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rify function names ## Context NOTE: This diff is a WIP. I still have to replace some callsites and make sure there are no performance regressions. However, I'm seeking some preliminary feedback on the new function names in `indexing_utils.h` The goal of this diff is to clean up the `indexing_utils.h` header file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing. ## Notes for reviewers As for the last diff, the majority of meaningful changes are in `indexing_utils.h` and the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const. Differential Revision: [D62901892](https://our.internmc.facebook.com/intern/diff/D62901892/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5443
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit a5c9bb8 with merge base 5a3eceb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62901892 |
SS-JIA
added a commit
that referenced
this pull request
Sep 17, 2024
…rify function names ## Context NOTE: This diff is a WIP. I still have to replace some callsites and make sure there are no performance regressions. However, I'm seeking some preliminary feedback on the new function names in `indexing_utils.h` The goal of this diff is to clean up the `indexing_utils.h` header file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing. ## Notes for reviewers As for the last diff, the majority of meaningful changes are in `indexing_utils.h` and the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const. Differential Revision: [D62901892](https://our.internmc.facebook.com/intern/diff/D62901892/) ghstack-source-id: 243148490 Pull Request resolved: #5443
….h` and clarify function names" ## Context NOTE: This diff is a WIP. I still have to replace some callsites and make sure there are no performance regressions. However, I'm seeking some preliminary feedback on the new function names in `indexing_utils.h` The goal of this diff is to clean up the `indexing_utils.h` header file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing. ## Notes for reviewers As for the last diff, the majority of meaningful changes are in `indexing_utils.h` and the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const. Differential Revision: [D62901892](https://our.internmc.facebook.com/intern/diff/D62901892/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Sep 18, 2024
…rify function names Pull Request resolved: #5443 ## Context The goal of this diff is to clean up the `indexing_utils.h` header file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing. ## Notes for reviewers As with the last diff, the majority of meaningful changes are in `indexing_utils.h` and the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const. Differential Revision: [D62901892](https://our.internmc.facebook.com/intern/diff/D62901892/) ghstack-source-id: 243353336
|
This pull request was exported from Phabricator. Differential Revision: D62901892 |
….h` and clarify function names" ## Context NOTE: This diff is a WIP. I still have to replace some callsites and make sure there are no performance regressions. However, I'm seeking some preliminary feedback on the new function names in `indexing_utils.h` The goal of this diff is to clean up the `indexing_utils.h` header file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing. ## Notes for reviewers As for the last diff, the majority of meaningful changes are in `indexing_utils.h` and the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const. Differential Revision: [D62901892](https://our.internmc.facebook.com/intern/diff/D62901892/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Sep 18, 2024
…rify function names Pull Request resolved: #5443 ## Context The goal of this diff is to clean up the `indexing_utils.h` header file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing. ## Notes for reviewers As with the last diff, the majority of meaningful changes are in `indexing_utils.h` and the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const. ghstack-source-id: 243358248 Differential Revision: [D62901892](https://our.internmc.facebook.com/intern/diff/D62901892/)
|
This pull request was exported from Phabricator. Differential Revision: D62901892 |
junpi3
approved these changes
Sep 18, 2024
….h` and clarify function names" ## Context NOTE: This diff is a WIP. I still have to replace some callsites and make sure there are no performance regressions. However, I'm seeking some preliminary feedback on the new function names in `indexing_utils.h` The goal of this diff is to clean up the `indexing_utils.h` header file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing. ## Notes for reviewers As for the last diff, the majority of meaningful changes are in `indexing_utils.h` and the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const. Differential Revision: [D62901892](https://our.internmc.facebook.com/intern/diff/D62901892/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Sep 18, 2024
…rify function names Pull Request resolved: #5443 ## Context The goal of this diff is to clean up the `indexing_utils.h` header file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing. ## Notes for reviewers As with the last diff, the majority of meaningful changes are in `indexing_utils.h` and the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const. ghstack-source-id: 243365712 Differential Revision: [D62901892](https://our.internmc.facebook.com/intern/diff/D62901892/)
|
This pull request was exported from Phabricator. Differential Revision: D62901892 |
|
This pull request has been merged in e148c1d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
indexing_utils.hand clarify function names #5443Context
NOTE: This diff is a WIP. I still have to replace some callsites and make sure there are no performance regressions. However, I'm seeking some preliminary feedback on the new function names in
indexing_utils.hThe goal of this diff is to clean up the
indexing_utils.hheader file to introduce more consistent terminology for tensor properties and improve the function names so that they are crystal clear on what they are doing.Notes for reviewers
As for the last diff, the majority of meaningful changes are in
indexing_utils.hand the rest are changes to function names. There should be no functionality changes, with the exception of re-writing functions which interact with texture position so that input arguments can be const.Differential Revision: D62901892