Skip to content

[ET-VK][ez] Use MemoryAccessFlags instead of MemoryAccessType when binding #5583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[ET-VK][ez] Use MemoryAccessFlags instead of MemoryAccessType when binding #5583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d1a808
[ET-VK][ez] Use `MemoryAccessFlags` instead of `MemoryAccessType` whe…
SS-JIA Sep 24, 2024
16e8320
Update on "[ET-VK][ez] Use `MemoryAccessFlags` instead of `MemoryAcce…
SS-JIA Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions backends/vulkan/runtime/graph/ops/ExecuteNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ class ComputeGraph;
* access permission.
*/
struct ArgGroup {
ArgGroup(const ValueRef ref, const vkapi::MemoryAccessType access)
ArgGroup(const ValueRef ref, const vkapi::MemoryAccessFlags access)
: refs{ref}, access(access) {}

ArgGroup(
const std::vector<ValueRef>& refs,
const vkapi::MemoryAccessType access)
const vkapi::MemoryAccessFlags access)
: refs(refs), access(access) {}

const std::vector<ValueRef> refs;
const vkapi::MemoryAccessType access;
const vkapi::MemoryAccessFlags access;
};

/*
Expand Down
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/utils/BindingUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace vkcompute {
void bind_tensor_to_descriptor_set(
api::vTensor& tensor,
vkapi::PipelineBarrier& pipeline_barrier,
const vkapi::MemoryAccessType accessType,
const vkapi::MemoryAccessFlags accessType,
vkapi::DescriptorSet& descriptor_set,
const uint32_t idx) {
if (tensor.buffer()) {
Expand Down
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/utils/BindingUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace vkcompute {
void bind_tensor_to_descriptor_set(
api::vTensor& tensor,
vkapi::PipelineBarrier& pipeline_barrier,
const vkapi::MemoryAccessType accessType,
const vkapi::MemoryAccessFlags accessType,
vkapi::DescriptorSet& descriptor_set,
const uint32_t idx);

Expand Down
Loading