[ET-VK][ez] Use MemoryAccessFlags instead of MemoryAccessType when binding
#5591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n binding ## Context Correct `ComputeGraph` functions to accept `MemoryAccessFlags` instead of `MemoryAccessType`. `MemoryAccessType` correspond to only a single bit, i.e. `READ` or `WRITE` but `MemoryAccessFlags` allows us to express a combination of bits which is the intended behaviour. Differential Revision: [D63327080](https://our.internmc.facebook.com/intern/diff/D63327080/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5591
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fdee70e with merge base df72b8c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63327080 |
This was referenced Sep 24, 2024
junpi3
approved these changes
Sep 24, 2024
|
This pull request has been merged in f1c5fc6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
MemoryAccessFlagsinstead ofMemoryAccessTypewhen binding #5591Context
Correct
ComputeGraphfunctions to acceptMemoryAccessFlagsinstead ofMemoryAccessType.MemoryAccessTypecorrespond to only a single bit, i.e.READorWRITEbutMemoryAccessFlagsallows us to express a combination of bits which is the intended behaviour.Differential Revision: D63327080