Update NDK version to r26d in docs #5612
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5612
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9874230 with merge base 99ee547 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
|
||
|
|
||
| Note: This demo app and tutorial has only been validated with arm64-v8a [ABI](https://developer.android.com/ndk/guides/abis), with NDK 25.0.8775105. | ||
| Note: This demo app and tutorial has only been validated with arm64-v8a [ABI](https://developer.android.com/ndk/guides/abis), with NDK r26d. |
There was a problem hiding this comment.
@kirklandsign , can we specifically call out the version number (v26.3.11579264)?
There was a problem hiding this comment.
I feel like r26d is the official name from android pages. The version number v26.3.11579264 only appears on sdkmanager
There was a problem hiding this comment.
But let me know if you think v26.3.11579264 is more accurate
There was a problem hiding this comment.
I made a commit on top of yours to address this.
There was a problem hiding this comment.
oops sorry, my page didn't refresh so just saw this now. Just to keep format of previous the same, are you ok with v26.3.11579264 then we continue with this?
There was a problem hiding this comment.
Yes! v26.3.11579264 works for me!
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kirklandsign merged this pull request in 85e7458. |
No description provided.