Skip to content

Get export APIs ready for PTC #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
angelayi wants to merge 1 commit into from
Closed

Get export APIs ready for PTC #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions exir/capture/_capture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import warnings
from collections import namedtuple
from typing import Any, Callable, Dict, List, Optional, Set, Tuple, Union
from unittest.mock import patch

import torch
import torch._export
Expand Down Expand Up @@ -125,9 +124,8 @@ def capture( # noqa: C901
"Functionalization is required for enable_aot.",
)

# TODO remove this later
with patch("torch._export.DECOMP_TABLE", _default_decomposition_table()):
ep = export(f, args, constraints=constraints)
ep = export(f, args, constraints=constraints)
ep = ep.run_decompositions(_default_decomposition_table()) # pyre-ignore[6]
ep = ep._transform(ReplaceViewOpsWithViewCopyOpsPass())
if not config._unlift:
return ExirExportedProgram(ep, False)
Expand Down
1 change: 1 addition & 0 deletions exir/program/TARGETS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ python_library(
"//executorch/exir:pass_manager",
"//executorch/exir:print_program",
"//executorch/exir:schema",
"//executorch/exir:tracer",
"//executorch/exir/_serialize:lib",
"//executorch/exir/backend:backend_api",
"//executorch/exir/backend:partitioner",
Expand Down
6 changes: 6 additions & 0 deletions exir/program/_program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from executorch.exir.passes.spec_prop_pass import SpecPropPass
from executorch.exir.print_program import pretty_print, print_program
from executorch.exir.schema import Program
from executorch.exir.tracer import _default_decomposition_table
from executorch.exir.verification.verifier import (
EXIRATenDialectVerifier,
EXIREdgeDialectVerifier,
Expand Down Expand Up @@ -589,6 +590,11 @@ def to_edge(

edge_programs: Dict[str, ExportedProgram] = {}
for name, program in aten_programs.items():
# Decompose to Core ATen
program = program.run_decompositions(
_default_decomposition_table() # pyre-ignore[6]
)

if config._check_ir_validity:
try:
EXIRATenDialectVerifier()(program.graph_module)
Expand Down
4 changes: 2 additions & 2 deletions exir/program/test/test_program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ def foo(x: torch.Tensor) -> torch.Tensor:
torch.ones(1),
torch.zeros(1),
),
)
).run_decompositions()
programs["foo"] = export(
foo,
(torch.ones(1),),
)
).run_decompositions()
return programs


Expand Down