[ExecuTorch] Stop using deleter for TensorPtr #5683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual deletion operation is not custom. Writing our own TensorPtr class avoids the confusing deleter and allows us to forbid the bugprone release() operation, which would likely cause the Tensor to dangle. It also highlights that I'm not sure why the Tensor in TensorPtr needs to be on the heap -- now that we don't need the deleter mechanism, it seems like we could put the Tensor inline and perhaps rename TensorPtr to OwningTensor. Differential Revision: [D63467583](https://our.internmc.facebook.com/intern/diff/D63467583/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5683
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit bc8bc21 with merge base d2ba238 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63467583 |
This was referenced Sep 26, 2024
|
folding into #5684 |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
The actual deletion operation is not custom. Writing our own TensorPtr class avoids the confusing deleter and allows us to forbid the bugprone release() operation, which would likely cause the Tensor to dangle. It also highlights that I'm not sure why the Tensor in TensorPtr needs to be on the heap -- now that we don't need the deleter mechanism, it seems like we could put the Tensor inline and perhaps rename TensorPtr to OwningTensor. Differential Revision: [D63467583](https://our.internmc.facebook.com/intern/diff/D63467583/) ghstack-source-id: 244865772 Pull Request resolved: pytorch/executorch#5683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The actual deletion operation is not custom. Writing our own TensorPtr class avoids the confusing deleter and allows us to forbid the bugprone release() operation, which would likely cause the Tensor to dangle.
It also highlights that I'm not sure why the Tensor in TensorPtr needs to be on the heap -- now that we don't need the deleter mechanism, it seems like we could put the Tensor inline and perhaps rename TensorPtr to OwningTensor.
Differential Revision: D63467583