Skip to content

[ExecuTorch] Remove TensorPtr::get() #5687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[ExecuTorch] Remove TensorPtr::get() #5687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba6fc1e
[ExecuTorch] Remove TensorPtr::get()
swolchok Sep 26, 2024
43167e9
Update on "[ExecuTorch] Remove TensorPtr::get()"
swolchok Sep 26, 2024
f25043a
Update on "[ExecuTorch] Remove TensorPtr::get()"
swolchok Sep 26, 2024
92bd162
Update on "[ExecuTorch] Remove TensorPtr::get()"
swolchok Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions extension/tensor/tensor_ptr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,13 @@ class TensorPtr {
return static_cast<bool>(tensor_impl_);
}

exec_aten::Tensor* get() const {
return tensor_impl_ ? &tensor_ : nullptr;
}

exec_aten::Tensor* operator->() const {
return get();
return tensor_impl_ ? &tensor_ : nullptr;
}

exec_aten::Tensor& operator*() const {
ET_DCHECK(*this != nullptr);
return *get();
return *operator->();
}

void reset() {
Expand Down
4 changes: 0 additions & 4 deletions extension/tensor/test/tensor_ptr_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,17 @@ TEST_F(TensorPtrTest, BasicSmartPointerAccess) {
TensorPtr p;
EXPECT_FALSE(p);
EXPECT_EQ(p, nullptr);
EXPECT_EQ(p.get(), nullptr);
EXPECT_EQ(p.operator->(), nullptr);
TensorPtr p2 = make_tensor_ptr({1}, nullptr, {}, {});
EXPECT_TRUE(p2);
EXPECT_NE(p2, nullptr);
ASSERT_NE(p2.get(), nullptr);
ASSERT_NE(p2.operator->(), nullptr);
EXPECT_EQ(p2.get(), p2.operator->());
EXPECT_EQ(p2->dim(), 1);
EXPECT_EQ((*p2).dim(), 1);
EXPECT_NE(p, p2);
p2.reset();
EXPECT_FALSE(p2);
EXPECT_EQ(p2, nullptr);
EXPECT_EQ(p2.get(), nullptr);
EXPECT_EQ(p2.operator->(), nullptr);
EXPECT_EQ(p, p2);
}
Expand Down
4 changes: 2 additions & 2 deletions extension/training/examples/XOR/train.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ int main(int argc, char** argv) {
for (int i = 0; i < num_epochs; i++) {
int index = dist(URBG);
auto& data = data_set[index];
const auto& results = mod.execute_forward_backward(
"forward", {*data.first.get(), *data.second.get()});
const auto& results =
mod.execute_forward_backward("forward", {*data.first, *data.second});
if (results.error() != Error::Ok) {
ET_LOG(Error, "Failed to execute forward_backward");
return 1;
Expand Down
Loading