Show loading model UI during model switch #5691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5691
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 97ac359 with merge base 7e9eaa8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62512275 |
kirklandsign
approved these changes
Sep 26, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62512275 |
cmodi-meta
added a commit
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: #5691 Destructing a model takes about 5 seconds of time. Previously, if the user switched models then "loading model..." would only show 5 seconds after the model was destructed. To help UX we will show "loading model..." before we we destroy the model. This way the user will know that app has ack'd that a model refresh needs to happen. Reviewed By: kirklandsign Differential Revision: D62512275
cmodi-meta
force-pushed
the
export-D62512275
branch
from
9cf6508 to
6e392e9
Compare
Summary: Destructing a model takes about 5 seconds of time. Previously, if the user switched models then "loading model..." would only show 5 seconds after the model was destructed. To help UX we will show "loading model..." before we we destroy the model. This way the user will know that app has ack'd that a model refresh needs to happen. Reviewed By: kirklandsign Differential Revision: D62512275
facebook-github-bot
force-pushed
the
export-D62512275
branch
from
6e392e9 to
97ac359
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62512275 |
|
This pull request has been merged in d4afbe7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Destructing a model takes about 5 seconds of time. Previously, if the user switched models then "loading model..." would only show 5 seconds after the model was destructed.
To help UX we will show "loading model..." before we we destroy the model. This way the user will know that app has ack'd that a model refresh needs to happen.
Reviewed By: kirklandsign
Differential Revision: D62512275